Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1704203004: Update Crashpad to badfacccee01895719d2aeb3ac50f64854abf10c (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to badfacccee01895719d2aeb3ac50f64854abf10c badfacccee01 win: Add support for capturing unloaded modules R=mark@chromium.org BUG=587141, crashpad:89 Committed: https://crrev.com/29fa84e5f10c4ddfd20973bd4162d3f31dd4ebda Cr-Commit-Position: refs/heads/master@{#376091}

Patch Set 1 #

Patch Set 2 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+856 lines, -11 lines) Patch
M build/secondary/third_party/crashpad/crashpad/minidump/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/compat/non_win/dbghelp.h View 3 chunks +58 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/win/crashy_test_program.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_extensions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_file_writer.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer.h View 1 chunk +154 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer.cc View 1 chunk +203 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer_test.cc View 1 chunk +162 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_writable_test_util.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_writable_test_util.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/process_snapshot.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/snapshot.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/test/test_process_snapshot.h View 4 chunks +12 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/test/test_process_snapshot.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/snapshot/unloaded_module_snapshot.h View 1 chunk +61 lines, -0 lines 0 comments Download
A + third_party/crashpad/crashpad/snapshot/unloaded_module_snapshot.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/end_to_end_test.py View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h View 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc View 4 chunks +55 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/nt_internals.h View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/nt_internals.cc View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
scottmg
4 years, 10 months ago (2016-02-18 03:10:11 UTC) #1
Mark Mentovai
LGTM
4 years, 10 months ago (2016-02-18 03:54:12 UTC) #2
Mark Mentovai
badfacccee!
4 years, 10 months ago (2016-02-18 03:54:25 UTC) #3
scottmg
:) I was pretty surprised to see that hash come up!
4 years, 10 months ago (2016-02-18 04:16:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704203004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704203004/20001
4 years, 10 months ago (2016-02-18 04:18:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 04:26:03 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 04:28:17 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/29fa84e5f10c4ddfd20973bd4162d3f31dd4ebda
Cr-Commit-Position: refs/heads/master@{#376091}

Powered by Google App Engine
This is Rietveld 408576698