third_party/crashpad/crashpad/minidump/minidump_file_writer.cc - Issue 1704203004: Update Crashpad to badfacccee01895719d2aeb3ac50f64854abf10c

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_file_writer.cc

Issue 1704203004: Update Crashpad to badfacccee01895719d2aeb3ac50f64854abf10c (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/minidump_extensions.h ('k') | third_party/crashpad/crashpad/minidump/minidump_test.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/minidump_file_writer.cc

diff --git a/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc b/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc

index 9b540d32eac37f983f9930beefe4f07157862448..0c79c78d80278914d0e4d13bb258191bbd2d16f4 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc

+++ b/third_party/crashpad/crashpad/minidump/minidump_file_writer.cc

@@ -27,6 +27,7 @@

#include "minidump/minidump_system_info_writer.h"

#include "minidump/minidump_thread_id_map.h"

#include "minidump/minidump_thread_writer.h"

+#include "minidump/minidump_unloaded_module_writer.h"

#include "minidump/minidump_writer_util.h"

#include "snapshot/exception_snapshot.h"

#include "snapshot/process_snapshot.h"

@@ -95,6 +96,14 @@ void MinidumpFileWriter::InitializeFromSnapshot(

module_list->InitializeFromSnapshot(process_snapshot->Modules());

AddStream(std::move(module_list));

+ auto unloaded_modules = process_snapshot->UnloadedModules();

+ if (!unloaded_modules.empty()) {

+ auto unloaded_module_list =

+ make_scoped_ptr(new MinidumpUnloadedModuleListWriter());

+ unloaded_module_list->InitializeFromSnapshot(unloaded_modules);

+ AddStream(std::move(unloaded_module_list));

+ }

auto crashpad_info = make_scoped_ptr(new MinidumpCrashpadInfoWriter());

crashpad_info->InitializeFromSnapshot(process_snapshot);