Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: third_party/crashpad/crashpad/handler/win/crashy_test_program.cc

Issue 1704203004: Update Crashpad to badfacccee01895719d2aeb3ac50f64854abf10c (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
diff --git a/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc b/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
index f9e8501f80f40cc80f7437271e99f225abcd0a98..51ff012959c23bd00d338af08c5e98f84ea8ec4f 100644
--- a/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
+++ b/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
@@ -165,6 +165,16 @@ int CrashyMain(int argc, wchar_t* argv[]) {
return EXIT_FAILURE;
}
+ // Load and unload some uncommonly used modules so we can see them in the list
+ // reported by `lm`. At least two so that we confirm we got the size of
+ // RTL_UNLOAD_EVENT_TRACE right.
+ CHECK(GetModuleHandle(L"lz32.dll") == nullptr);
+ CHECK(GetModuleHandle(L"wmerror.dll") == nullptr);
+ HMODULE lz32 = LoadLibrary(L"lz32.dll");
+ HMODULE wmerror = LoadLibrary(L"wmerror.dll");
+ FreeLibrary(lz32);
+ FreeLibrary(wmerror);
+
// Make sure data pointed to by the stack is captured.
const int kDataSize = 512;
int* pointed_to_data = new int[kDataSize];
« no previous file with comments | « third_party/crashpad/crashpad/compat/non_win/dbghelp.h ('k') | third_party/crashpad/crashpad/minidump/minidump.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698