Replace slots buffer with remembered set.

Replace slots buffer with remembered set.

Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>.

The remembered set is extended to support typed slots.

During parallel evacuation all migration slots are recorded in local slots buffers.
After evacuation all local slots are added to the remembered set.

BUG=chromium:578883
LOG=NO

Committed: https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152
Cr-Commit-Position: refs/heads/master@{#34212}

[ulan, 2016-02-22 11:49:09]

Description was changed from

==========
Replace slots buffer with remembered set.

BUG=chromium:578883
LOG=NO
==========

to

==========
Replace slots buffer with remembered set.

Slots pointing to evacuation candidates are now recorded in the new
RememberedSet<OLD_TO_OLD>.

The remembered set is extended to support typed slots.

BUG=chromium:578883
LOG=NO
==========

[ulan, 2016-02-22 13:28:23]

Description was changed from

==========
Replace slots buffer with remembered set.

Slots pointing to evacuation candidates are now recorded in the new
RememberedSet<OLD_TO_OLD>.

The remembered set is extended to support typed slots.

BUG=chromium:578883
LOG=NO
==========

to

==========
Replace slots buffer with remembered set.

Slots pointing to evacuation candidates are now recorded in the new
RememberedSet<OLD_TO_OLD>.

The remembered set is extended to support typed slots.

During parallel evacuation all migration slots are recorded in local slots
buffers.
After evacuation all local slots are added to the remembered set.

BUG=chromium:578883
LOG=NO
==========

[ulan, 2016-02-22 14:38:27]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org, jochen@chromium.org, mlippautz@chromium.org

[ulan, 2016-02-22 14:38:28]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org, jochen@chromium.org, mlippautz@chromium.org

[ulan, 2016-02-22 14:38:28]

PTAL

[ulan, 2016-02-22 14:38:29]

PTAL

[jochen (gone - plz use gerrit), 2016-02-23 13:10:54]

lgtm with comments

https://codereview.chromium.org/1703823002/diff/230001/src/heap/mark-compact-...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1703823002/diff/230001/src/heap/mark-compact-...
src/heap/mark-compact-inl.h:76: RememberedSet<OLD_TO_OLD>::Insert(source_page,
so we now just crash if we can't grow the remembered set?

https://codereview.chromium.org/1703823002/diff/230001/src/heap/remembered-set.h
File src/heap/remembered-set.h (right):

https://codereview.chromium.org/1703823002/diff/230001/src/heap/remembered-se...
src/heap/remembered-set.h:210: // Buffer for keeping thead local migration slots
during compation.
compaction

https://codereview.chromium.org/1703823002/diff/230001/src/heap/remembered-se...
src/heap/remembered-set.h:229: DCHECK_GT(entry,
static_cast<uintptr_t>(NUMBER_OF_SLOT_TYPES));
GE would be enough, no?

[ulan, 2016-02-23 13:19:07]

Thanks!

https://codereview.chromium.org/1703823002/diff/230001/src/heap/mark-compact-...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1703823002/diff/230001/src/heap/mark-compact-...
src/heap/mark-compact-inl.h:76: RememberedSet<OLD_TO_OLD>::Insert(source_page,
On 2016/02/23 13:10:53, jochen wrote:
> so we now just crash if we can't grow the remembered set?

Yes, as discussed offline, the remembered set filters out duplicates so its size
is limited.

https://codereview.chromium.org/1703823002/diff/230001/src/heap/remembered-set.h
File src/heap/remembered-set.h (right):

https://codereview.chromium.org/1703823002/diff/230001/src/heap/remembered-se...
src/heap/remembered-set.h:210: // Buffer for keeping thead local migration slots
during compation.
On 2016/02/23 13:10:54, jochen wrote:
> compaction

Done.

https://codereview.chromium.org/1703823002/diff/230001/src/heap/remembered-se...
src/heap/remembered-set.h:229: DCHECK_GT(entry,
static_cast<uintptr_t>(NUMBER_OF_SLOT_TYPES));
On 2016/02/23 13:10:54, jochen wrote:
> GE would be enough, no?

Yes. Done.

[ulan, 2016-02-23 13:23:31]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-02-23 13:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1703823002/#ps250001
(title: "Address comments")

[commit-bot: I haz the power, 2016-02-23 13:23:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703823002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703823002/250001

[commit-bot: I haz the power, 2016-02-23 13:52:43]

Description was changed from

==========
Replace slots buffer with remembered set.

Slots pointing to evacuation candidates are now recorded in the new
RememberedSet<OLD_TO_OLD>.

The remembered set is extended to support typed slots.

During parallel evacuation all migration slots are recorded in local slots
buffers.
After evacuation all local slots are added to the remembered set.

BUG=chromium:578883
LOG=NO
==========

to

==========
Replace slots buffer with remembered set.

Slots pointing to evacuation candidates are now recorded in the new
RememberedSet<OLD_TO_OLD>.

The remembered set is extended to support typed slots.

During parallel evacuation all migration slots are recorded in local slots
buffers.
After evacuation all local slots are added to the remembered set.

BUG=chromium:578883
LOG=NO
==========

[commit-bot: I haz the power, 2016-02-23 13:52:44]

Committed patchset #14 (id:250001)

[commit-bot: I haz the power, 2016-02-23 13:53:08]

Description was changed from

==========
Replace slots buffer with remembered set.

Slots pointing to evacuation candidates are now recorded in the new
RememberedSet<OLD_TO_OLD>.

The remembered set is extended to support typed slots.

During parallel evacuation all migration slots are recorded in local slots
buffers.
After evacuation all local slots are added to the remembered set.

BUG=chromium:578883
LOG=NO
==========

to

==========
Replace slots buffer with remembered set.

Slots pointing to evacuation candidates are now recorded in the new
RememberedSet<OLD_TO_OLD>.

The remembered set is extended to support typed slots.

During parallel evacuation all migration slots are recorded in local slots
buffers.
After evacuation all local slots are added to the remembered set.

BUG=chromium:578883
LOG=NO

Committed: https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152
Cr-Commit-Position: refs/heads/master@{#34212}
==========

[commit-bot: I haz the power, 2016-02-23 13:53:09]

Patchset 14 (id:??) landed as
https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152
Cr-Commit-Position: refs/heads/master@{#34212}

[ulan, 2016-02-24 09:47:34]

A revert of this CL (patchset #14 id:250001) has been created in
https://codereview.chromium.org/1725073003/ by ulan@chromium.org.

The reason for reverting is: Revert because of canary crashes: crbug.com/589413.