MD Settings: Manage search engines, localizing/adding strings.

MD Settings: Manage search engines, localizing/adding strings.

BUG=479359
Committed: https://crrev.com/042ab1d869d327f5b187a40d12165ba9fcd248a1
Cr-Commit-Position: refs/heads/master@{#376518}

[dpapad, 2016-02-16 22:28:20]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-02-16 23:45:17]

looks pretty good to me

I wonder if translators get more than just the [desc] as the entire context. 
I've always written descriptions as if that /all/ they get to go on.  Look at
your [desc] and make sure it does this or figure out if they get additional
context ;), IMO.

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:442: <message
name="IDS_SETTINGS_SEARCH_MANAGE_MANAGE_SEARCH_ENGINES" desc="Label for the
Manage Search Engines button.">
why why IDS_SETTINGS_SEARCH_MANAGE_MANAGE_SEARCH_ENGINES ? ?

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:443: Manage search engines
are the mocks not title case?  also, I assume most of this moot as THE BUTTONS
LOOK LIKE THIS?

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:468: <message
name="IDS_SETTINGS_SEARCH_ENGINES_NOT_VALID" desc="Text indicating that the
input to a given text field is invalid.">
maybe make this search engines specific as well

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:483: <message
name="IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_EXPLANATION" desc="Label for
explaining the format of the URL that should be entered by the user.">
mention that this is in the search engines page somehow (like the previous
description)

https://codereview.chromium.org/1703703002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engines_list.html
(right):

https://codereview.chromium.org/1703703002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_list.html:9:
<div class="name" i18n-content="searchEnginesSearchEngine"></div>
searchEnginesName?

[dpapad, 2016-02-17 00:00:17]

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:442: <message
name="IDS_SETTINGS_SEARCH_MANAGE_MANAGE_SEARCH_ENGINES" desc="Label for the
Manage Search Engines button.">
On 2016/02/16 at 23:45:17, Dan Beam wrote:
> why why IDS_SETTINGS_SEARCH_MANAGE_MANAGE_SEARCH_ENGINES ? ?

By accident, fixed.

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:443: Manage search engines
On 2016/02/16 at 23:45:17, Dan Beam wrote:
> are the mocks not title case?  also, I assume most of this moot as THE BUTTONS
LOOK LIKE THIS?

This string is used twice,
1) As "MANAGE SEARCH ENGINES" to open the search engines page (meant to be
capitalized by CSS text transform).
2) As "Manage search engines" as the title of the (animated) page.

Title case is not used anywhere in the mocks for this particular string.

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:468: <message
name="IDS_SETTINGS_SEARCH_ENGINES_NOT_VALID" desc="Text indicating that the
input to a given text field is invalid.">
On 2016/02/16 at 23:45:17, Dan Beam wrote:
> maybe make this search engines specific as well

Done.

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:483: <message
name="IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_EXPLANATION" desc="Label for
explaining the format of the URL that should be entered by the user.">
On 2016/02/16 at 23:45:17, Dan Beam wrote:
> mention that this is in the search engines page somehow (like the previous
description)

Done.

https://codereview.chromium.org/1703703002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engines_list.html
(right):

https://codereview.chromium.org/1703703002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_list.html:9:
<div class="name" i18n-content="searchEnginesSearchEngine"></div>
On 2016/02/16 at 23:45:17, Dan Beam wrote:
> searchEnginesName?

The English text for this string is "Search engine" so I am trying to use the
following naming convention when naming global loadTimeData entries. 

<namespace><camel-cased string>, where namespace is "searchEngines" and the
string is "searchEngine"

[Dan Beam, 2016-02-17 00:07:30]

lgtm

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/1703703002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:443: Manage search engines
On 2016/02/17 00:00:17, dpapad wrote:
> On 2016/02/16 at 23:45:17, Dan Beam wrote:
> > are the mocks not title case?  also, I assume most of this moot as THE
BUTTONS
> LOOK LIKE THIS?
> 
> This string is used twice,
> 1) As "MANAGE SEARCH ENGINES" to open the search engines page (meant to be
> capitalized by CSS text transform).
> 2) As "Manage search engines" as the title of the (animated) page.
> 
> Title case is not used anywhere in the mocks for this particular string.

sweet, thanks for explaining

https://codereview.chromium.org/1703703002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/search_engines_page/search_engines_list.html
(right):

https://codereview.chromium.org/1703703002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_engines_page/search_engines_list.html:9:
<div class="name" i18n-content="searchEnginesSearchEngine"></div>
On 2016/02/17 00:00:17, dpapad wrote:
> On 2016/02/16 at 23:45:17, Dan Beam wrote:
> > searchEnginesName?
> 
> The English text for this string is "Search engine" so I am trying to use the
> following naming convention when naming global loadTimeData entries. 
> 
> <namespace><camel-cased string>, where namespace is "searchEngines" and the
> string is "searchEngine"

yeah, i think this is probably gonna suck no matter what, lol (it'll be
confusing as "name" and confusing as "searchEngines"), so whatever

[dpapad, 2016-02-19 18:43:18]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-02-19 18:43:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1703703002/#ps40001
(title: "Update string based on Alan's latest response.")

[commit-bot: I haz the power, 2016-02-19 18:45:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703703002/40001

[commit-bot: I haz the power, 2016-02-19 19:52:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-19 19:53:12]

Description was changed from

==========
MD Settings: Manage search engines, localizing/adding strings.

BUG=479359
==========

to

==========
MD Settings: Manage search engines, localizing/adding strings.

BUG=479359

Committed: https://crrev.com/042ab1d869d327f5b187a40d12165ba9fcd248a1
Cr-Commit-Position: refs/heads/master@{#376518}
==========

[commit-bot: I haz the power, 2016-02-19 19:53:13]

Patchset 3 (id:??) landed as
https://crrev.com/042ab1d869d327f5b187a40d12165ba9fcd248a1
Cr-Commit-Position: refs/heads/master@{#376518}