chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js - Issue 1703703002: MD Settings: Manage search engines, localizing/adding strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

Issue 1703703002: MD Settings: Manage search engines, localizing/adding strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manage_search_engines_ui1

Patch Set: Update string based on Alan's latest response. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html ('k') | chrome/browser/resources/settings/search_engines_page/search_engines_list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

index 42d344ec57f968231fb98c6d6787d91f3d98e0cd..10e4e29fe21f9751c80ca9edf0f5f4f0f8675ce9 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

@@ -55,18 +55,18 @@ Polymer({

/** @override */

ready: function() {

if (this.model) {

- // TODO(dpapad): Localize strings.

- this.dialogTitle_ = 'Edit search engine';

- this.actionButtonText_ = 'Edit';

+ this.dialogTitle_ =

+ loadTimeData.getString('searchEnginesEditSearchEngine');

+ this.actionButtonText_ = loadTimeData.getString('save');

// If editing an existing search engine, pre-populate the input fields.

this.searchEngine_ = this.model.displayName;

this.keyword_ = this.model.keyword;

this.queryUrl_ = this.model.url;

} else {

- // TODO(dpapad): Localize string.

- this.dialogTitle_ = 'Add search engine';

- this.actionButtonText_ = loadTimeData.getString('searchEnginesAdd');

+ this.dialogTitle_ =

+ loadTimeData.getString('searchEnginesAddSearchEngine');

+ this.actionButtonText_ = loadTimeData.getString('add');

}