Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 1703703002: MD Settings: Manage search engines, localizing/adding strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manage_search_engines_ui1
Patch Set: Update string based on Alan's latest response. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 21 matching lines...) Expand all
32 #include "ui/chromeos/strings/grit/ui_chromeos_strings.h" 32 #include "ui/chromeos/strings/grit/ui_chromeos_strings.h"
33 #endif 33 #endif
34 34
35 namespace { 35 namespace {
36 36
37 // Note that settings.html contains a <script> tag which imports a script of 37 // Note that settings.html contains a <script> tag which imports a script of
38 // the following name. These names must be kept in sync. 38 // the following name. These names must be kept in sync.
39 const char kLocalizedStringsFile[] = "strings.js"; 39 const char kLocalizedStringsFile[] = "strings.js";
40 40
41 void AddCommonStrings(content::WebUIDataSource* html_source) { 41 void AddCommonStrings(content::WebUIDataSource* html_source) {
42 html_source->AddLocalizedString("add", IDS_ADD);
43 html_source->AddLocalizedString("cancel", IDS_CANCEL);
44 html_source->AddLocalizedString("learnMore", IDS_LEARN_MORE);
45 html_source->AddLocalizedString("ok", IDS_OK);
46 html_source->AddLocalizedString("save", IDS_SAVE);
47
48 html_source->AddLocalizedString("advancedPageTitle", IDS_SETTINGS_ADVANCED);
42 html_source->AddLocalizedString("basicPageTitle", IDS_SETTINGS_BASIC); 49 html_source->AddLocalizedString("basicPageTitle", IDS_SETTINGS_BASIC);
43 html_source->AddLocalizedString("advancedPageTitle", IDS_SETTINGS_ADVANCED);
44 html_source->AddLocalizedString("addLabel", IDS_ADD);
45 html_source->AddLocalizedString("learnMore", IDS_LEARN_MORE);
46 html_source->AddLocalizedString("cancel", IDS_CANCEL);
47 html_source->AddLocalizedString("ok", IDS_OK);
48 html_source->AddLocalizedString("settings", IDS_SETTINGS_SETTINGS); 50 html_source->AddLocalizedString("settings", IDS_SETTINGS_SETTINGS);
49 } 51 }
50 52
51 #if defined(OS_CHROMEOS) 53 #if defined(OS_CHROMEOS)
52 void AddA11yStrings(content::WebUIDataSource* html_source) { 54 void AddA11yStrings(content::WebUIDataSource* html_source) {
53 html_source->AddLocalizedString( 55 html_source->AddLocalizedString(
54 "a11yPageTitle", IDS_SETTINGS_ACCESSIBILITY); 56 "a11yPageTitle", IDS_SETTINGS_ACCESSIBILITY);
55 html_source->AddLocalizedString( 57 html_source->AddLocalizedString(
56 "moreFeaturesLink", IDS_SETTINGS_MORE_FEATURES_LINK); 58 "moreFeaturesLink", IDS_SETTINGS_MORE_FEATURES_LINK);
57 html_source->AddLocalizedString( 59 html_source->AddLocalizedString(
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 IDS_SETTINGS_CLEAR_DATA); 648 IDS_SETTINGS_CLEAR_DATA);
647 html_source->AddLocalizedString("titleAndCount", 649 html_source->AddLocalizedString("titleAndCount",
648 IDS_SETTINGS_TITLE_AND_COUNT); 650 IDS_SETTINGS_TITLE_AND_COUNT);
649 } 651 }
650 652
651 void AddSearchStrings(content::WebUIDataSource* html_source) { 653 void AddSearchStrings(content::WebUIDataSource* html_source) {
652 html_source->AddLocalizedString("searchPageTitle", 654 html_source->AddLocalizedString("searchPageTitle",
653 IDS_SETTINGS_SEARCH); 655 IDS_SETTINGS_SEARCH);
654 html_source->AddLocalizedString("searchExplanation", 656 html_source->AddLocalizedString("searchExplanation",
655 IDS_SETTINGS_SEARCH_EXPLANATION); 657 IDS_SETTINGS_SEARCH_EXPLANATION);
656 html_source->AddLocalizedString("searchManageButtonLabel", 658 html_source->AddLocalizedString(
657 IDS_SETTINGS_SEARCH_MANAGE_BUTTON_LABEL); 659 "searchEnginesManage",
660 IDS_SETTINGS_SEARCH_MANAGE_SEARCH_ENGINES);
658 html_source->AddLocalizedString("searchOkGoogleLabel", 661 html_source->AddLocalizedString("searchOkGoogleLabel",
659 IDS_SETTINGS_SEARCH_OK_GOOGLE_LABEL); 662 IDS_SETTINGS_SEARCH_OK_GOOGLE_LABEL);
660 html_source->AddLocalizedString( 663 html_source->AddLocalizedString(
661 "searchOkGoogleLearnMoreLink", 664 "searchOkGoogleLearnMoreLink",
662 IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE_LINK); 665 IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE_LINK);
663 html_source->AddLocalizedString( 666 html_source->AddLocalizedString(
664 "searchOkGoogleDescriptionLabel", 667 "searchOkGoogleDescriptionLabel",
665 IDS_SETTINGS_SEARCH_OK_GOOGLE_DESCRIPTION_LABEL); 668 IDS_SETTINGS_SEARCH_OK_GOOGLE_DESCRIPTION_LABEL);
666 } 669 }
667 670
668 void AddSearchEnginesStrings(content::WebUIDataSource* html_source) { 671 void AddSearchEnginesStrings(content::WebUIDataSource* html_source) {
669 html_source->AddLocalizedString("searchEnginesPageTitle", 672 html_source->AddLocalizedString("searchEnginesPageTitle",
670 IDS_SETTINGS_SEARCH_ENGINES); 673 IDS_SETTINGS_SEARCH_ENGINES);
671 html_source->AddLocalizedString( 674 html_source->AddLocalizedString(
672 "searchEnginesAddSearchEngineLabel", 675 "searchEnginesAddSearchEngine",
673 IDS_SETTINGS_SEARCH_ENGINES_ADD_SEARCH_ENGINE_LABEL); 676 IDS_SETTINGS_SEARCH_ENGINES_ADD_SEARCH_ENGINE);
674 html_source->AddLocalizedString("searchEnginesLabel",
675 IDS_SETTINGS_SEARCH_ENGINES_LABEL);
676 html_source->AddLocalizedString( 677 html_source->AddLocalizedString(
677 "searchEnginesOtherLabel", 678 "searchEnginesEditSearchEngine",
678 IDS_SETTINGS_SEARCH_ENGINES_OTHER_ENGINES_LABEL); 679 IDS_SETTINGS_SEARCH_ENGINES_EDIT_SEARCH_ENGINE);
679 html_source->AddLocalizedString( 680 html_source->AddLocalizedString(
680 "searchEnginesSearchEngineLabel", 681 "searchEnginesNotValid",
681 IDS_SETTINGS_SEARCH_ENGINES_SEARCH_ENGINE_LABEL); 682 IDS_SETTINGS_SEARCH_ENGINES_NOT_VALID);
682 html_source->AddLocalizedString("searchEnginesKeywordLabel", 683 html_source->AddLocalizedString("searchEngines",
683 IDS_SETTINGS_SEARCH_ENGINES_KEYWORD_LABEL); 684 IDS_SETTINGS_SEARCH_ENGINES);
684 html_source->AddLocalizedString("searchEnginesQueryURLLabel",
685 IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_LABEL);
686 html_source->AddLocalizedString( 685 html_source->AddLocalizedString(
687 "searchEnginesAdd", IDS_SETTINGS_SEARCH_ENGINES_ADD); 686 "searchEnginesOther",
687 IDS_SETTINGS_SEARCH_ENGINES_OTHER_ENGINES);
688 html_source->AddLocalizedString(
689 "searchEnginesSearchEngine",
690 IDS_SETTINGS_SEARCH_ENGINES_SEARCH_ENGINE);
691 html_source->AddLocalizedString("searchEnginesKeyword",
692 IDS_SETTINGS_SEARCH_ENGINES_KEYWORD);
693 html_source->AddLocalizedString("searchEnginesQueryURL",
694 IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL);
695 html_source->AddLocalizedString(
696 "searchEnginesQueryURLExplanation",
697 IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_EXPLANATION);
688 html_source->AddLocalizedString( 698 html_source->AddLocalizedString(
689 "searchEnginesMakeDefault", IDS_SETTINGS_SEARCH_ENGINES_MAKE_DEFAULT); 699 "searchEnginesMakeDefault", IDS_SETTINGS_SEARCH_ENGINES_MAKE_DEFAULT);
690 html_source->AddLocalizedString( 700 html_source->AddLocalizedString(
691 "searchEnginesEdit", IDS_SETTINGS_SEARCH_ENGINES_EDIT); 701 "searchEnginesEdit", IDS_SETTINGS_SEARCH_ENGINES_EDIT);
692 html_source->AddLocalizedString( 702 html_source->AddLocalizedString(
693 "searchEnginesRemoveFromList", 703 "searchEnginesRemoveFromList",
694 IDS_SETTINGS_SEARCH_ENGINES_REMOVE_FROM_LIST); 704 IDS_SETTINGS_SEARCH_ENGINES_REMOVE_FROM_LIST);
695 } 705 }
696 706
697 void AddSiteSettingsStrings(content::WebUIDataSource* html_source) { 707 void AddSiteSettingsStrings(content::WebUIDataSource* html_source) {
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
909 AddSiteSettingsStrings(html_source); 919 AddSiteSettingsStrings(html_source);
910 AddUsersStrings(html_source); 920 AddUsersStrings(html_source);
911 AddWebContentStrings(html_source); 921 AddWebContentStrings(html_source);
912 922
913 policy_indicator::AddLocalizedStrings(html_source); 923 policy_indicator::AddLocalizedStrings(html_source);
914 924
915 html_source->SetJsonPath(kLocalizedStringsFile); 925 html_source->SetJsonPath(kLocalizedStringsFile);
916 } 926 }
917 927
918 } // namespace settings 928 } // namespace settings
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698