Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1703563002: [Interpreter] Remove some cctest and mjsunit test skips. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove some cctest and mjsunit test skips. Removes some cctest and mjsunit test skips on Ignition for tests that now pass. BUG=v8:4680 LOG=N Committed: https://crrev.com/5b2d1956eb0ce6ca76882c93a7b991bb4029584e Cr-Commit-Position: refs/heads/master@{#34045}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703563002/1
4 years, 10 months ago (2016-02-16 16:08:30 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13835)
4 years, 10 months ago (2016-02-16 16:22:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703563002/20001
4 years, 10 months ago (2016-02-16 17:03:19 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/12309)
4 years, 10 months ago (2016-02-16 17:14:42 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703563002/40001
4 years, 10 months ago (2016-02-16 17:22:18 UTC) #10
rmcilroy
Michi, PTAL, thanks.
4 years, 10 months ago (2016-02-16 17:31:35 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 17:41:41 UTC) #14
Michael Starzinger
LGTM (rubber-stamped).
4 years, 10 months ago (2016-02-16 17:56:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703563002/40001
4 years, 10 months ago (2016-02-16 18:50:00 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-16 18:51:36 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 18:52:20 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b2d1956eb0ce6ca76882c93a7b991bb4029584e
Cr-Commit-Position: refs/heads/master@{#34045}

Powered by Google App Engine
This is Rietveld 408576698