Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1738143002: [Interpreter] Rebaseline ForOf bytecode generator tests. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Rebaseline ForOf bytecode generator tests. Rebaselines ForOf bytecodes after shipping iterator finalization in https://codereview.chromium.org/1738463003/. TBR=adamk@chromium.org BUG=v8:3566, v8:4280 LOG=N Committed: https://crrev.com/a0fdb33f1caeb6f6cffc2ac5a9245e297e145a24 Cr-Commit-Position: refs/heads/master@{#34329}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+608 lines, -97 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 8 chunks +608 lines, -93 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738143002/1
4 years, 10 months ago (2016-02-26 12:29:33 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/15966)
4 years, 10 months ago (2016-02-26 12:47:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738143002/20001
4 years, 10 months ago (2016-02-26 13:57:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-26 14:22:12 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 14:22:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0fdb33f1caeb6f6cffc2ac5a9245e297e145a24
Cr-Commit-Position: refs/heads/master@{#34329}

Powered by Google App Engine
This is Rietveld 408576698