Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1894063002: [Interpreter] Remove register file register and replace with LoadParentFramePointer. (Closed)

Created:
4 years, 8 months ago by rmcilroy
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove register file register and replace with LoadParentFramePointer. Removes the register file machine register from the interpreter and replaces it will loads from the parent frame pointer. As part of this change the raw operand values for register values changes to enable the interpreter to keep using the operand value as the offset from the parent frame pointer. BUG=v8:4280 LOG=N Committed: https://crrev.com/623ad7de882019dff10168ef53bd539f01ef5b93 Cr-Commit-Position: refs/heads/master@{#35618}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add ports #

Patch Set 4 : Fix unittest #

Patch Set 5 : Fix typo #

Patch Set 6 : Fix gcc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -377 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 4 5 4 chunks +5 lines, -18 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 4 4 chunks +5 lines, -18 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/frames.h View 1 1 chunk +3 lines, -12 lines 0 comments Download
M src/frames.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 4 4 chunks +7 lines, -20 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/interface-descriptors.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 3 4 5 25 chunks +35 lines, -53 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 2 3 4 5 4 chunks +17 lines, -4 lines 0 comments Download
M src/interpreter/bytecodes.cc View 1 2 3 4 5 2 chunks +47 lines, -19 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 5 chunks +15 lines, -32 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 4 4 chunks +5 lines, -18 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 4 4 chunks +5 lines, -18 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 4 chunks +7 lines, -21 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WideRegisters.golden View 8 chunks +24 lines, -24 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/interpreter/bytecodes-unittest.cc View 1 2 3 3 chunks +6 lines, -15 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 14 chunks +31 lines, -57 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 45 (24 generated)
rmcilroy
Orion / Benedikt, please take a look. If everyone is happy I'll port to the ...
4 years, 8 months ago (2016-04-18 09:13:08 UTC) #2
Benedikt Meurer
+mstarzinger
4 years, 8 months ago (2016-04-18 09:23:18 UTC) #5
oth
Nice. LGTM. Thanks.
4 years, 8 months ago (2016-04-18 10:57:13 UTC) #6
Benedikt Meurer
LGTM from my side.
4 years, 8 months ago (2016-04-19 04:22:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894063002/1
4 years, 8 months ago (2016-04-19 07:53:21 UTC) #9
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
4 years, 8 months ago (2016-04-19 07:53:23 UTC) #11
rmcilroy
On 2016/04/19 07:53:23, commit-bot: I haz the power wrote: > All required reviewers (with asterisk ...
4 years, 8 months ago (2016-04-19 07:55:19 UTC) #15
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-19 08:10:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894063002/1
4 years, 8 months ago (2016-04-19 08:15:01 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/346) v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-19 08:16:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894063002/20001
4 years, 8 months ago (2016-04-19 09:31:34 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/5922)
4 years, 8 months ago (2016-04-19 09:35:08 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894063002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894063002/60001
4 years, 8 months ago (2016-04-19 10:21:10 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4485)
4 years, 8 months ago (2016-04-19 10:24:02 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894063002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894063002/80001
4 years, 8 months ago (2016-04-19 10:37:10 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/362)
4 years, 8 months ago (2016-04-19 10:42:21 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894063002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894063002/100001
4 years, 8 months ago (2016-04-19 11:33:43 UTC) #36
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 11:56:36 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894063002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894063002/100001
4 years, 8 months ago (2016-04-19 12:45:20 UTC) #41
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-19 12:47:32 UTC) #43
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:48:50 UTC) #45
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/623ad7de882019dff10168ef53bd539f01ef5b93
Cr-Commit-Position: refs/heads/master@{#35618}

Powered by Google App Engine
This is Rietveld 408576698