Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 17035012: Change general fill rect shader code to match geometry vers (Closed)

Created:
7 years, 6 months ago by egdaniel
Modified:
7 years, 6 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Change general fill rect shader code to match geometry vers -Matches shader implemented for alligned rects -Uses multiplication instead of min (used in geom version) to combine width and height coverages R=bsalomon@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9626

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M src/gpu/GrAARectRenderer.cpp View 1 2 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
egdaniel
I have tested this change on the rects and dashing3 gm to compare to the ...
7 years, 6 months ago (2013-06-14 18:45:53 UTC) #1
bsalomon
On 2013/06/14 18:45:53, egdaniel wrote: > I have tested this change on the rects and ...
7 years, 6 months ago (2013-06-14 19:05:07 UTC) #2
robertphillips
lgtm
7 years, 6 months ago (2013-06-14 19:18:15 UTC) #3
egdaniel
7 years, 6 months ago (2013-06-14 19:25:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r9626 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698