Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1703433002: Move DIP(WIndow) to Viewport conversion code for drag&drop from browser to renderer (Closed)

Created:
4 years, 10 months ago by oshima
Modified:
4 years, 10 months ago
Reviewers:
no sievers
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DIP(WIndow) to Viewport conversion code for drag&drop from browser to renderer. This is improvement to the original CL (https://codereview.chromium.org/1605143003). I should have done this way because most of conversion happens in RenderWidget/RenderViewImpl. BUG=485650 Committed: https://crrev.com/4300f52e922e14a8f94f59ac55e86e640e9e7799 Cr-Commit-Position: refs/heads/master@{#376280}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -29 lines) Patch
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 4 chunks +10 lines, -23 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 4 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703433002/20001
4 years, 10 months ago (2016-02-16 07:59:36 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 09:04:56 UTC) #4
oshima
4 years, 10 months ago (2016-02-17 02:44:37 UTC) #8
no sievers
lgtm
4 years, 10 months ago (2016-02-18 20:21:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703433002/20001
4 years, 10 months ago (2016-02-18 20:25:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 21:51:12 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 21:52:23 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4300f52e922e14a8f94f59ac55e86e640e9e7799
Cr-Commit-Position: refs/heads/master@{#376280}

Powered by Google App Engine
This is Rietveld 408576698