Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 1703433002: Move DIP(WIndow) to Viewport conversion code for drag&drop from browser to renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 5aa3313f278c865aab9af9280ba91a1ab0569b27..12d7b727c9a4644963f6abc7c37037108cb39063 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -682,11 +682,9 @@ void RenderViewHostImpl::DragTargetDragEnter(
.append(register_name));
}
- const gfx::Point client_pt_in_viewport = ConvertDIPToViewport(client_pt);
-
- Send(new DragMsg_TargetDragEnter(GetRoutingID(), filtered_data,
- client_pt_in_viewport, screen_pt,
- operations_allowed, key_modifiers));
+ Send(new DragMsg_TargetDragEnter(GetRoutingID(), filtered_data, client_pt,
+ screen_pt, operations_allowed,
+ key_modifiers));
}
void RenderViewHostImpl::DragTargetDragOver(
@@ -694,10 +692,8 @@ void RenderViewHostImpl::DragTargetDragOver(
const gfx::Point& screen_pt,
WebDragOperationsMask operations_allowed,
int key_modifiers) {
- const gfx::Point client_pt_in_viewport = ConvertDIPToViewport(client_pt);
- Send(new DragMsg_TargetDragOver(GetRoutingID(), client_pt_in_viewport,
- screen_pt, operations_allowed,
- key_modifiers));
+ Send(new DragMsg_TargetDragOver(GetRoutingID(), client_pt, screen_pt,
+ operations_allowed, key_modifiers));
}
void RenderViewHostImpl::DragTargetDragLeave() {
@@ -708,18 +704,17 @@ void RenderViewHostImpl::DragTargetDrop(
const gfx::Point& client_pt,
const gfx::Point& screen_pt,
int key_modifiers) {
- const gfx::Point client_pt_in_viewport = ConvertDIPToViewport(client_pt);
- Send(new DragMsg_TargetDrop(GetRoutingID(), client_pt_in_viewport, screen_pt,
+ Send(new DragMsg_TargetDrop(GetRoutingID(), client_pt, screen_pt,
key_modifiers));
}
void RenderViewHostImpl::DragSourceEndedAt(
int client_x, int client_y, int screen_x, int screen_y,
WebDragOperation operation) {
- const gfx::Point client_pt_in_viewport =
- ConvertDIPToViewport(gfx::Point(client_x, client_y));
- Send(new DragMsg_SourceEnded(GetRoutingID(), client_pt_in_viewport,
- gfx::Point(screen_x, screen_y), operation));
+ Send(new DragMsg_SourceEnded(GetRoutingID(),
+ gfx::Point(client_x, client_y),
+ gfx::Point(screen_x, screen_y),
+ operation));
}
void RenderViewHostImpl::DragSourceSystemDragEnded() {
@@ -1368,12 +1363,4 @@ void RenderViewHostImpl::RenderViewReady() {
delegate_->RenderViewReady(this);
}
-gfx::Point RenderViewHostImpl::ConvertDIPToViewport(const gfx::Point& point) {
- // The point in guest view is already converted.
- if (!render_widget_host_->scale_input_to_viewport())
- return point;
- float scale = GetWidget()->GetView()->current_device_scale_factor();
- return gfx::Point(point.x() * scale, point.y() * scale);
-}
-
} // namespace content
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698