Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1605143003: [UseZoomForDSF] Support drag&drop (Closed)

Created:
4 years, 11 months ago by oshima
Modified:
4 years, 10 months ago
Reviewers:
no sievers, dcheng
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, gavinp+loader_chromium.org, jam, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, tyoshino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UseZoomForDSF] Support drag&drop * Scale drag/drop events to Viewport in RenderViewHostImpl. * Scale the drag offset to Window/DIP in RenderViewImpl. * Use the screen info's scale factor to tag the drag image. * Make sure that the target image size passed to clampedImageScale is in DIP. BUG=485650 TEST=manual. I'll add a unit test after https://codereview.chromium.org/1586923002/ is landed. Committed: https://crrev.com/b331323047cf6c2c3fb288f45573f2897a5168da Cr-Commit-Position: refs/heads/master@{#371950}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Total comments: 2

Patch Set 5 : added comment #

Total comments: 1

Patch Set 6 : #

Patch Set 7 : guest view support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -20 lines) Patch
M content/browser/renderer_host/render_view_host_impl.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 5 6 4 chunks +23 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 2 3 4 5 6 6 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 59 (32 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/80001
4 years, 11 months ago (2016-01-20 08:51:12 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/147736)
4 years, 11 months ago (2016-01-20 09:05:02 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/100001
4 years, 11 months ago (2016-01-20 09:22:50 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/154642)
4 years, 11 months ago (2016-01-20 10:20:38 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/120001
4 years, 11 months ago (2016-01-20 20:02:29 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/140001
4 years, 11 months ago (2016-01-20 20:29:14 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/104630) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 11 months ago (2016-01-20 20:35:33 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/160001
4 years, 11 months ago (2016-01-20 22:05:42 UTC) #27
dcheng
https://codereview.chromium.org/1605143003/diff/160001/content/browser/renderer_host/render_view_host_impl.h File content/browser/renderer_host/render_view_host_impl.h (right): https://codereview.chromium.org/1605143003/diff/160001/content/browser/renderer_host/render_view_host_impl.h#newcode364 content/browser/renderer_host/render_view_host_impl.h:364: gfx::Point convertDipToViewport(const gfx::Point& point); This should be named ConvertDipToViewport() ...
4 years, 11 months ago (2016-01-20 22:48:11 UTC) #28
oshima
https://codereview.chromium.org/1605143003/diff/160001/content/browser/renderer_host/render_view_host_impl.h File content/browser/renderer_host/render_view_host_impl.h (right): https://codereview.chromium.org/1605143003/diff/160001/content/browser/renderer_host/render_view_host_impl.h#newcode364 content/browser/renderer_host/render_view_host_impl.h:364: gfx::Point convertDipToViewport(const gfx::Point& point); On 2016/01/20 22:48:11, dcheng wrote: ...
4 years, 11 months ago (2016-01-20 23:25:31 UTC) #29
oshima
ping?
4 years, 11 months ago (2016-01-22 16:49:46 UTC) #30
dcheng
https://codereview.chromium.org/1605143003/diff/180001/third_party/WebKit/Source/core/page/DragController.cpp File third_party/WebKit/Source/core/page/DragController.cpp (right): https://codereview.chromium.org/1605143003/diff/180001/third_party/WebKit/Source/core/page/DragController.cpp#newcode893 third_party/WebKit/Source/core/page/DragController.cpp:893: dragImage = dragImageForImage(element, image, dragOrigin, imageRect.location(), imageSizeInDIP, dragLocation); I ...
4 years, 11 months ago (2016-01-22 17:37:41 UTC) #31
oshima
uploaded new patch with the comment. PTAL. https://codereview.chromium.org/1605143003/diff/180001/third_party/WebKit/Source/core/page/DragController.cpp File third_party/WebKit/Source/core/page/DragController.cpp (right): https://codereview.chromium.org/1605143003/diff/180001/third_party/WebKit/Source/core/page/DragController.cpp#newcode893 third_party/WebKit/Source/core/page/DragController.cpp:893: dragImage = ...
4 years, 11 months ago (2016-01-22 22:49:02 UTC) #32
dcheng
> This is because dragImageForImage clips the image in screen coordinates in DIP, > which ...
4 years, 11 months ago (2016-01-26 18:52:15 UTC) #33
oshima
On 2016/01/26 18:52:15, dcheng wrote: > > This is because dragImageForImage clips the image in ...
4 years, 11 months ago (2016-01-26 20:10:43 UTC) #34
dcheng
On 2016/01/26 at 20:10:43, oshima wrote: > On 2016/01/26 18:52:15, dcheng wrote: > > > ...
4 years, 11 months ago (2016-01-26 22:07:01 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/220001
4 years, 11 months ago (2016-01-27 18:08:18 UTC) #37
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/240001
4 years, 11 months ago (2016-01-27 18:46:29 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/260001
4 years, 11 months ago (2016-01-27 18:50:05 UTC) #44
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-27 20:15:23 UTC) #46
dcheng
lgtm
4 years, 10 months ago (2016-01-27 22:41:44 UTC) #47
oshima
+sievers@ for content/ OWNER
4 years, 10 months ago (2016-01-27 23:06:13 UTC) #51
no sievers
lgtm. though seems a bit unfortunate that the distinction now bleeds into more places rather ...
4 years, 10 months ago (2016-01-27 23:11:05 UTC) #52
oshima
On 2016/01/27 23:11:05, sievers wrote: > lgtm. though seems a bit unfortunate that the distinction ...
4 years, 10 months ago (2016-01-28 01:04:30 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605143003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605143003/260001
4 years, 10 months ago (2016-01-28 01:06:37 UTC) #55
commit-bot: I haz the power
Committed patchset #7 (id:260001)
4 years, 10 months ago (2016-01-28 01:13:32 UTC) #57
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 01:16:37 UTC) #59
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/b331323047cf6c2c3fb288f45573f2897a5168da
Cr-Commit-Position: refs/heads/master@{#371950}

Powered by Google App Engine
This is Rietveld 408576698