Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17034006: Add base namespace to more values in sync and elsewhere. (Closed)

Created:
7 years, 6 months ago by brettw
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, akalin, albertb+watch_chromium.org, grt+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, apatrick_chromium, feature-media-reviews_chromium.org, eroman, darin-cc_chromium.org, tim (not reviewing), oshima+watch_chromium.org, Raghu Simha, cc-bugs_chromium.org, stevenjb+watch_chromium.org, haitaol1, mmenke
Visibility:
Public.

Description

Add base namespace to more values in sync and elsewhere. This makes sync and net compile with no "using *Value". BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -244 lines) Patch
M cc/base/math_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_map.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M chrome/tools/build/generate_policy_source.py View 5 chunks +10 lines, -10 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_manager_client_stub.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/certificate_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/cros_network_functions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/device_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/network_ui_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_merger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/shill_property_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/gaia/google_service_auth_error.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_control_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M jingle/glue/utils.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M media/base/media_log_event.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_log.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/cert/crl_set.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/dns/dns_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_netlog_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/sync_change_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M sync/api/sync_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/engine/traffic_logger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/engine/traffic_recorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/traffic_recorder.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M sync/engine/traffic_recorder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/base_node.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M sync/internal_api/change_record.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/js_mutation_event_observer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/js_sync_encryption_handler_observer.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/base/invalidation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/base/model_type_invalidation_map.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/base/model_type_invalidation_map_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/public/base/progress_marker_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/change_record_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/public/engine/model_safe_worker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/sessions/sync_source_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/sessions/sync_source_info_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/js/js_arg_list.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/js/js_arg_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/js/js_event_details.h View 1 chunk +4 lines, -3 lines 0 comments Download
M sync/js/js_event_details.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M sync/js/js_event_details_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/js/js_test_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M sync/notifier/object_id_invalidation_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/notifier/p2p_invalidator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M sync/protocol/proto_value_conversions_unittest.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M sync/protocol/sync_protocol_error.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/protocol/sync_protocol_error.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/entry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/entry_kernel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/model_type_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/syncable/nigori_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/test/accounts_client/test_accounts_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/util.h View 4 chunks +16 lines, -14 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ui/webui/jstemplate_builder.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/webui/web_ui_util.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/webui/web_ui_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
TBR=tim
7 years, 6 months ago (2013-06-18 21:24:24 UTC) #1
akalin
Probably mean tim@chromium.org.
7 years, 6 months ago (2013-06-18 21:25:16 UTC) #2
brettw
7 years, 6 months ago (2013-06-21 19:42:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r207907.

Powered by Google App Engine
This is Rietveld 408576698