Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: sync/js/js_event_details_unittest.cc

Issue 17034006: Add base namespace to more values in sync and elsewhere. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/js/js_event_details.cc ('k') | sync/js/js_test_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/js/js_event_details.h" 5 #include "sync/js/js_event_details.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace syncer { 10 namespace syncer {
11 namespace { 11 namespace {
12 12
13 class JsEventDetailsTest : public testing::Test {}; 13 class JsEventDetailsTest : public testing::Test {};
14 14
15 TEST_F(JsEventDetailsTest, EmptyList) { 15 TEST_F(JsEventDetailsTest, EmptyList) {
16 JsEventDetails details; 16 JsEventDetails details;
17 EXPECT_TRUE(details.Get().empty()); 17 EXPECT_TRUE(details.Get().empty());
18 EXPECT_EQ("{}", details.ToString()); 18 EXPECT_EQ("{}", details.ToString());
19 } 19 }
20 20
21 TEST_F(JsEventDetailsTest, FromDictionary) { 21 TEST_F(JsEventDetailsTest, FromDictionary) {
22 DictionaryValue dict; 22 base::DictionaryValue dict;
23 dict.SetString("foo", "bar"); 23 dict.SetString("foo", "bar");
24 dict.Set("baz", new ListValue()); 24 dict.Set("baz", new base::ListValue());
25 25
26 scoped_ptr<DictionaryValue> dict_copy(dict.DeepCopy()); 26 scoped_ptr<base::DictionaryValue> dict_copy(dict.DeepCopy());
27 27
28 JsEventDetails details(&dict); 28 JsEventDetails details(&dict);
29 29
30 // |details| should take over |dict|'s data. 30 // |details| should take over |dict|'s data.
31 EXPECT_TRUE(dict.empty()); 31 EXPECT_TRUE(dict.empty());
32 EXPECT_TRUE(details.Get().Equals(dict_copy.get())); 32 EXPECT_TRUE(details.Get().Equals(dict_copy.get()));
33 } 33 }
34 34
35 } // namespace 35 } // namespace
36 } // namespace syncer 36 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/js/js_event_details.cc ('k') | sync/js/js_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698