Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: sync/internal_api/js_sync_manager_observer.cc

Issue 17034006: Add base namespace to more values in sync and elsewhere. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/js_sync_manager_observer.cc
diff --git a/sync/internal_api/js_sync_manager_observer.cc b/sync/internal_api/js_sync_manager_observer.cc
index cbc9996092366d4a6802e1267d3c4a6428c80f79..01ddda834a3ecc0c2a95fe9ac1200cbeafff33c4 100644
--- a/sync/internal_api/js_sync_manager_observer.cc
+++ b/sync/internal_api/js_sync_manager_observer.cc
@@ -34,7 +34,7 @@ void JsSyncManagerObserver::OnSyncCycleCompleted(
if (!event_handler_.IsInitialized()) {
return;
}
- DictionaryValue details;
+ base::DictionaryValue details;
details.Set("snapshot", snapshot.ToValue());
HandleJsEvent(FROM_HERE, "onSyncCycleCompleted", JsEventDetails(&details));
}
@@ -43,7 +43,7 @@ void JsSyncManagerObserver::OnConnectionStatusChange(ConnectionStatus status) {
if (!event_handler_.IsInitialized()) {
return;
}
- DictionaryValue details;
+ base::DictionaryValue details;
details.SetString("status", ConnectionStatusToString(status));
HandleJsEvent(FROM_HERE,
"onConnectionStatusChange", JsEventDetails(&details));
@@ -53,7 +53,7 @@ void JsSyncManagerObserver::OnUpdatedToken(const std::string& token) {
if (!event_handler_.IsInitialized()) {
return;
}
- DictionaryValue details;
+ base::DictionaryValue details;
details.SetString("token", "<redacted>");
HandleJsEvent(FROM_HERE, "onUpdatedToken", JsEventDetails(&details));
}
@@ -63,7 +63,7 @@ void JsSyncManagerObserver::OnActionableError(
if (!event_handler_.IsInitialized()) {
return;
}
- DictionaryValue details;
+ base::DictionaryValue details;
details.Set("syncError", sync_error.ToValue());
HandleJsEvent(FROM_HERE, "onActionableError",
JsEventDetails(&details));
@@ -79,7 +79,7 @@ void JsSyncManagerObserver::OnInitializationComplete(
// Ignore the |js_backend| argument; it's not really convertible to
// JSON anyway.
- DictionaryValue details;
+ base::DictionaryValue details;
details.Set("restoredTypes", ModelTypeSetToValue(restored_types));
HandleJsEvent(FROM_HERE,
« no previous file with comments | « sync/internal_api/js_sync_encryption_handler_observer.cc ('k') | sync/internal_api/js_sync_manager_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698