Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: content/common/gpu/gpu_command_buffer_stub.h

Issue 1703163002: Remove dependency on GURL from content/common/gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary include from gpu_command_buffer_stub Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_channel_unittest.cc ('k') | content/common/gpu/gpu_command_buffer_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_command_buffer_stub.h
diff --git a/content/common/gpu/gpu_command_buffer_stub.h b/content/common/gpu/gpu_command_buffer_stub.h
index 0a3fdbae26a7bc577c08a3498e6d3d29995a4093..0e5f6304ae6f07902695ec4e1dc5324ecb10cc30 100644
--- a/content/common/gpu/gpu_command_buffer_stub.h
+++ b/content/common/gpu/gpu_command_buffer_stub.h
@@ -34,7 +34,6 @@
#include "ui/gfx/swap_result.h"
#include "ui/gl/gl_surface.h"
#include "ui/gl/gpu_preference.h"
-#include "url/gurl.h"
namespace gpu {
struct Mailbox;
@@ -93,7 +92,7 @@ class GpuCommandBufferStub
int32_t route_id,
bool offscreen,
GpuWatchdog* watchdog,
- const GURL& active_url);
+ const std::string& active_url);
~GpuCommandBufferStub() override;
@@ -216,6 +215,10 @@ class GpuCommandBufferStub
void OnParseError();
void OnSchedulingChanged(bool scheduled);
+ // Shortcuts the expensive call to SetActiveURL when |url| is empty or
+ // |url_hash| matches the current active URL.
+ void FastSetActiveURL(const std::string& url, size_t url_hash);
+
void ReportState();
// Wrapper for GpuScheduler::PutChanged that sets the crash report URL.
@@ -285,7 +288,7 @@ class GpuCommandBufferStub
LatencyInfoCallback latency_info_callback_;
- GURL active_url_;
+ std::string active_url_;
size_t active_url_hash_;
scoped_ptr<WaitForCommandState> wait_for_token_;
« no previous file with comments | « content/common/gpu/gpu_channel_unittest.cc ('k') | content/common/gpu/gpu_command_buffer_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698