Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/common/gpu/gpu_channel_unittest.cc

Issue 1703163002: Remove dependency on GURL from content/common/gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary include from gpu_command_buffer_stub Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_channel_test_common.cc ('k') | content/common/gpu/gpu_command_buffer_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_channel_unittest.cc
diff --git a/content/common/gpu/gpu_channel_unittest.cc b/content/common/gpu/gpu_channel_unittest.cc
index 719d5479f2d258f2e05e316b3ff1a7d023a0c8ab..b940678c1a2583de3fe4876d8b48d2a0a2f95633 100644
--- a/content/common/gpu/gpu_channel_unittest.cc
+++ b/content/common/gpu/gpu_channel_unittest.cc
@@ -73,7 +73,7 @@ TEST_F(GpuChannelTest, CreateViewCommandBufferAllowed) {
init_params.stream_id = 0;
init_params.stream_priority = GpuStreamPriority::NORMAL;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
bool succeeded = false;
HandleMessage(channel, new GpuChannelMsg_CreateViewCommandBuffer(
@@ -100,7 +100,7 @@ TEST_F(GpuChannelTest, CreateViewCommandBufferDisallowed) {
init_params.stream_id = 0;
init_params.stream_priority = GpuStreamPriority::NORMAL;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
bool succeeded = false;
HandleMessage(channel, new GpuChannelMsg_CreateViewCommandBuffer(
@@ -125,7 +125,7 @@ TEST_F(GpuChannelTest, CreateOffscreenCommandBuffer) {
init_params.stream_id = 0;
init_params.stream_priority = GpuStreamPriority::NORMAL;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
bool succeeded = false;
HandleMessage(channel,
@@ -150,7 +150,7 @@ TEST_F(GpuChannelTest, IncompatibleStreamIds) {
init_params.stream_id = kStreamId1;
init_params.stream_priority = GpuStreamPriority::NORMAL;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
bool succeeded = false;
HandleMessage(channel,
@@ -169,7 +169,7 @@ TEST_F(GpuChannelTest, IncompatibleStreamIds) {
init_params.stream_id = kStreamId2;
init_params.stream_priority = GpuStreamPriority::NORMAL;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
succeeded = false;
HandleMessage(channel,
@@ -195,7 +195,7 @@ TEST_F(GpuChannelTest, IncompatibleStreamPriorities) {
init_params.stream_id = kStreamId1;
init_params.stream_priority = kStreamPriority1;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
bool succeeded = false;
HandleMessage(channel,
@@ -215,7 +215,7 @@ TEST_F(GpuChannelTest, IncompatibleStreamPriorities) {
init_params.stream_id = kStreamId2;
init_params.stream_priority = kStreamPriority2;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
succeeded = false;
HandleMessage(channel,
@@ -241,7 +241,7 @@ TEST_F(GpuChannelTest, StreamLifetime) {
init_params.stream_id = kStreamId1;
init_params.stream_priority = kStreamPriority1;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
bool succeeded = false;
HandleMessage(channel,
@@ -265,7 +265,7 @@ TEST_F(GpuChannelTest, StreamLifetime) {
init_params.stream_id = kStreamId2;
init_params.stream_priority = kStreamPriority2;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
succeeded = false;
HandleMessage(channel,
@@ -292,7 +292,7 @@ TEST_F(GpuChannelTest, RealTimeStreamsDisallowed) {
init_params.stream_id = kStreamId;
init_params.stream_priority = kStreamPriority;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
bool succeeded = false;
HandleMessage(channel,
@@ -319,7 +319,7 @@ TEST_F(GpuChannelTest, RealTimeStreamsAllowed) {
init_params.stream_id = kStreamId;
init_params.stream_priority = kStreamPriority;
init_params.attribs = std::vector<int>();
- init_params.active_url = GURL();
+ init_params.active_url = std::string();
init_params.gpu_preference = gfx::PreferIntegratedGpu;
bool succeeded = false;
HandleMessage(channel,
« no previous file with comments | « content/common/gpu/gpu_channel_test_common.cc ('k') | content/common/gpu/gpu_command_buffer_stub.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698