Rename DOMWindow interface to Window

Rename DOMWindow interface to Window

Stop using deprecated [InterfaceName] for the Window IDL interface.
Instead rename the file to Window.idl and use [ImplementedAs=DOMWindow].

Also rename Window partial interfaces accordingly.

R=haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152452

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152525

[haraken, 2013-06-14 13:53:24]

LGTM

abarth: Do you have any concern about this change?

[abarth-chromium, 2013-06-14 14:00:13]

No, this is great.

[commit-bot: I haz the power, 2013-06-14 14:12:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17031006/1

[commit-bot: I haz the power, 2013-06-14 15:00:32]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-06-14 15:09:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17031006/1

[do-not-use, 2013-06-14 15:13:46]

Committed patchset #1 manually as r152452 (presubmit successful).

[do-not-use, 2013-06-14 16:03:48]

Reopening as I reverted the patch in r152456.

It broke clean builds because make_event_factory does not understand
implementedAs yet (DOMWindow is an EventTarget).

[do-not-use, 2013-06-16 12:36:52]

I fixed the clean build, could you please take another look?

[haraken, 2013-06-16 23:39:54]

LGTM

[commit-bot: I haz the power, 2013-06-17 05:55:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17031006/18001

[commit-bot: I haz the power, 2013-06-17 05:55:50]

Failed to apply patch for Source/bindings/scripts/generate-bindings.pl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/scripts/generate-bindings.pl
  Hunk #3 FAILED at 161.
  1 out of 5 hunks FAILED -- saving rejects to file
Source/bindings/scripts/generate-bindings.pl.rej

Patch:       Source/bindings/scripts/generate-bindings.pl
Index: Source/bindings/scripts/generate-bindings.pl
diff --git a/Source/bindings/scripts/generate-bindings.pl
b/Source/bindings/scripts/generate-bindings.pl
index
1444fa0014875a81b1ba8b17a2bce34158d05586..072489848c82ff7db48710ab84a8127cef21a1dc
100755
--- a/Source/bindings/scripts/generate-bindings.pl
+++ b/Source/bindings/scripts/generate-bindings.pl
@@ -84,12 +84,12 @@ my @supplementedIdlFiles;
 if ($supplementalDependencyFile) {
     # The format of a supplemental dependency file:
     #
-    # DOMWindow.idl P.idl Q.idl R.idl
+    # Window.idl P.idl Q.idl R.idl
     # Document.idl S.idl
     # Event.idl
     # ...
     #
-    # The above indicates that DOMWindow.idl is supplemented by P.idl, Q.idl
and R.idl,
+    # The above indicates that Window.idl is supplemented by P.idl, Q.idl and
R.idl,
     # Document.idl is supplemented by S.idl, and Event.idl is supplemented by
no IDLs.
     # The IDL that supplements another IDL (e.g. P.idl) never appears in the
dependency file.
     open FH, "< $supplementalDependencyFile" or die "Cannot open
$supplementalDependencyFile\n";
@@ -150,9 +150,8 @@ foreach my $idlFile (@supplementedIdlFiles) {
                 $attribute->signature->extendedAttributes->{"ImplementedBy"} =
$interfaceName;
 
                 # Add interface-wide extended attributes to each attribute.
-                foreach my $extendedAttributeName (keys
%{$interface->extendedAttributes}) {
-                   
$attribute->signature->extendedAttributes->{$extendedAttributeName} =
$interface->extendedAttributes->{$extendedAttributeName};
-                }
+                applyInterfaceExtendedAttributes($interface,
$attribute->signature->extendedAttributes);
+
                 push(@{$targetDataNode->attributes}, $attribute);
             }
 
@@ -162,9 +161,8 @@ foreach my $idlFile (@supplementedIdlFiles) {
                 $function->signature->extendedAttributes->{"ImplementedBy"} =
$interfaceName;
 
                 # Add interface-wide extended attributes to each method.
-                foreach my $extendedAttributeName (keys
%{$interface->extendedAttributes}) {
-                   
$function->signature->extendedAttributes->{$extendedAttributeName} =
$interface->extendedAttributes->{$extendedAttributeName};
-                }
+                applyInterfaceExtendedAttributes($interface,
$function->signature->extendedAttributes);
+
                 push(@{$targetDataNode->functions}, $function);
             }
 
@@ -174,9 +172,8 @@ foreach my $idlFile (@supplementedIdlFiles) {
                 $constant->extendedAttributes->{"ImplementedBy"} =
$interfaceName;
 
                 # Add interface-wide extended attributes to each constant.
-                foreach my $extendedAttributeName (keys
%{$interface->extendedAttributes}) {
-                    $constant->extendedAttributes->{$extendedAttributeName} =
$interface->extendedAttributes->{$extendedAttributeName};
-                }
+                applyInterfaceExtendedAttributes($interface,
$constant->extendedAttributes);
+
                 push(@{$targetDataNode->constants}, $constant);
             }
         } else {
@@ -275,6 +272,17 @@ sub checkIDLAttributes
     }
 }
 
+sub applyInterfaceExtendedAttributes
+{
+    my $interface = shift;
+    my $extendedAttributes = shift;
+
+    foreach my $extendedAttributeName (keys %{$interface->extendedAttributes})
{
+        next if $extendedAttributeName eq "ImplementedAs";
+        $extendedAttributes->{$extendedAttributeName} =
$interface->extendedAttributes->{$extendedAttributeName};
+    }
+}
+
 sub checkIfIDLAttributesExists
 {
     my $idlAttributes = shift;

[commit-bot: I haz the power, 2013-06-17 06:07:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17031006/26001

[do-not-use, 2013-06-17 06:25:04]

Committed patchset #4 manually as r152525 (presubmit successful).

[eroman, 2013-06-18 21:15:51]

Would it make sense to rename the .cpp files as well?

For instance in WindowCrypto.idl  delete "ImplementedAs=DOMWindowCrypto" and
rename the class and files appropriately?

[haraken, 2013-06-18 23:55:16]

On 2013/06/18 21:15:51, eroman wrote:
> Would it make sense to rename the .cpp files as well?
> 
> For instance in WindowCrypto.idl  delete "ImplementedAs=DOMWindowCrypto" and
> rename the class and files appropriately?

If we want to do it, we should also rename DOMWindow to Window as well. That
sounds cool but might cause some naming conflict. (I don't know what is blocking
us from renaming DOMWindow to Window.)