Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/isolate.cc

Issue 1702593002: More simplification and unification of frame handling (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm64 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/frames.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/isolate.h" 5 #include "src/isolate.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <fstream> // NOLINT(readability/streams) 9 #include <fstream> // NOLINT(readability/streams)
10 #include <sstream> 10 #include <sstream>
(...skipping 1088 matching lines...) Expand 10 before | Expand all | Expand 10 after
1099 } 1099 }
1100 1100
1101 // For optimized frames we perform a lookup in the handler table. 1101 // For optimized frames we perform a lookup in the handler table.
1102 if (frame->is_optimized() && catchable_by_js) { 1102 if (frame->is_optimized() && catchable_by_js) {
1103 OptimizedFrame* js_frame = static_cast<OptimizedFrame*>(frame); 1103 OptimizedFrame* js_frame = static_cast<OptimizedFrame*>(frame);
1104 int stack_slots = 0; // Will contain stack slot count of frame. 1104 int stack_slots = 0; // Will contain stack slot count of frame.
1105 offset = js_frame->LookupExceptionHandlerInTable(&stack_slots, nullptr); 1105 offset = js_frame->LookupExceptionHandlerInTable(&stack_slots, nullptr);
1106 if (offset >= 0) { 1106 if (offset >= 0) {
1107 // Compute the stack pointer from the frame pointer. This ensures that 1107 // Compute the stack pointer from the frame pointer. This ensures that
1108 // argument slots on the stack are dropped as returning would. 1108 // argument slots on the stack are dropped as returning would.
1109 Address return_sp = frame->fp() - 1109 Address return_sp = frame->fp() +
1110 StandardFrameConstants::kFixedFrameSizeFromFp - 1110 StandardFrameConstants::kFixedFrameSizeAboveFp -
1111 stack_slots * kPointerSize; 1111 stack_slots * kPointerSize;
1112 1112
1113 // Gather information from the frame. 1113 // Gather information from the frame.
1114 code = frame->LookupCode(); 1114 code = frame->LookupCode();
1115 if (code->marked_for_deoptimization()) { 1115 if (code->marked_for_deoptimization()) {
1116 // If the target code is lazy deoptimized, we jump to the original 1116 // If the target code is lazy deoptimized, we jump to the original
1117 // return address, but we make a note that we are throwing, so that 1117 // return address, but we make a note that we are throwing, so that
1118 // the deoptimizer can do the right thing. 1118 // the deoptimizer can do the right thing.
1119 offset = static_cast<int>(frame->pc() - code->entry()); 1119 offset = static_cast<int>(frame->pc() - code->entry());
1120 set_deoptimizer_lazy_throw(true); 1120 set_deoptimizer_lazy_throw(true);
(...skipping 1744 matching lines...) Expand 10 before | Expand all | Expand 10 after
2865 // Then check whether this scope intercepts. 2865 // Then check whether this scope intercepts.
2866 if ((flag & intercept_mask_)) { 2866 if ((flag & intercept_mask_)) {
2867 intercepted_flags_ |= flag; 2867 intercepted_flags_ |= flag;
2868 return true; 2868 return true;
2869 } 2869 }
2870 return false; 2870 return false;
2871 } 2871 }
2872 2872
2873 } // namespace internal 2873 } // namespace internal
2874 } // namespace v8 2874 } // namespace v8
OLDNEW
« no previous file with comments | « src/frames.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698