Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1701793002: Remove HostDesktopType from startup browser creator (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
Robert Sesek, msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-24
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from startup browser creator R=msw@chromium.org BUG=558054 Committed: https://crrev.com/d625b603e56939f84562107c14fc7a5e09bd15a6 Cr-Commit-Position: refs/heads/master@{#376011}

Patch Set 1 #

Patch Set 2 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -111 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +2 lines, -15 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 25 chunks +25 lines, -47 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.h View 6 chunks +6 lines, -13 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 11 chunks +15 lines, -24 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc View 5 chunks +5 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1698123003 Patch 20001

Messages

Total messages: 19 (8 generated)
scottmg
4 years, 10 months ago (2016-02-15 22:14:16 UTC) #1
msw
lgtm
4 years, 10 months ago (2016-02-16 18:04:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701793002/1
4 years, 10 months ago (2016-02-17 18:52:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/181347)
4 years, 10 months ago (2016-02-17 19:10:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701793002/20001
4 years, 10 months ago (2016-02-17 19:13:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/146955)
4 years, 10 months ago (2016-02-17 19:27:39 UTC) #11
scottmg
Oops, +rsesek for .mm file.
4 years, 10 months ago (2016-02-17 22:17:13 UTC) #13
Robert Sesek
lgtm
4 years, 10 months ago (2016-02-17 22:20:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701793002/20001
4 years, 10 months ago (2016-02-17 22:34:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 22:43:44 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:45:53 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d625b603e56939f84562107c14fc7a5e09bd15a6
Cr-Commit-Position: refs/heads/master@{#376011}

Powered by Google App Engine
This is Rietveld 408576698