Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 1701793002: Remove HostDesktopType from startup browser creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-24
Patch Set: mac Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
index 7be189be5fdf330e2c07b883427eeb091610d6d2..1801b129180f4447a9fae3a51cadb0f1e1c60d11 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -63,7 +63,6 @@
#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/extensions/app_launch_params.h"
#include "chrome/browser/ui/extensions/application_launch.h"
-#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/session_crashed_bubble.h"
#include "chrome/browser/ui/startup/bad_flags_prompt.h"
#include "chrome/browser/ui/startup/default_browser_prompt.h"
@@ -308,8 +307,7 @@ StartupBrowserCreatorImpl::~StartupBrowserCreatorImpl() {
bool StartupBrowserCreatorImpl::Launch(Profile* profile,
const std::vector<GURL>& urls_to_open,
- bool process_startup,
- chrome::HostDesktopType desktop_type) {
+ bool process_startup) {
UMA_HISTOGRAM_COUNTS_100("Startup.BrowserLaunchURLCount",
static_cast<base::HistogramBase::Sample>(urls_to_open.size()));
RecordRapporOnStartupURLs(urls_to_open);
@@ -352,7 +350,7 @@ bool StartupBrowserCreatorImpl::Launch(Profile* profile,
RecordLaunchModeHistogram(urls_to_open.empty() ?
LM_TO_BE_DECIDED : LM_WITH_URLS);
- ProcessLaunchURLs(process_startup, urls_to_open, desktop_type);
+ ProcessLaunchURLs(process_startup, urls_to_open);
if (command_line_.HasSwitch(switches::kInstallChromeApp)) {
install_chrome_app::InstallChromeApp(
@@ -504,8 +502,7 @@ bool StartupBrowserCreatorImpl::OpenApplicationWindow(Profile* profile) {
void StartupBrowserCreatorImpl::ProcessLaunchURLs(
bool process_startup,
- const std::vector<GURL>& urls_to_open,
- chrome::HostDesktopType desktop_type) {
+ const std::vector<GURL>& urls_to_open) {
// Don't open any browser windows if we're starting up in "background mode".
if (process_startup && command_line_.HasSwitch(switches::kNoStartupWindow))
return;
@@ -522,7 +519,7 @@ void StartupBrowserCreatorImpl::ProcessLaunchURLs(
}
#endif
- if (process_startup && ProcessStartupURLs(urls_to_open, desktop_type)) {
+ if (process_startup && ProcessStartupURLs(urls_to_open)) {
// ProcessStartupURLs processed the urls, nothing else to do.
return;
}
@@ -549,7 +546,7 @@ void StartupBrowserCreatorImpl::ProcessLaunchURLs(
}
// Open user-specified URLs like pinned tabs and startup tabs.
- Browser* browser = ProcessSpecifiedURLs(urls_to_open, desktop_type);
+ Browser* browser = ProcessSpecifiedURLs(urls_to_open);
if (browser) {
AddInfoBarsIfNecessary(browser, is_process_startup);
return;
@@ -568,15 +565,13 @@ void StartupBrowserCreatorImpl::ProcessLaunchURLs(
}
// This will launch a browser; prevent session restore.
StartupBrowserCreator::in_synchronous_profile_launch_ = true;
- browser =
- OpenURLsInBrowser(browser, process_startup, adjusted_urls, desktop_type);
+ browser = OpenURLsInBrowser(browser, process_startup, adjusted_urls);
StartupBrowserCreator::in_synchronous_profile_launch_ = false;
AddInfoBarsIfNecessary(browser, is_process_startup);
}
bool StartupBrowserCreatorImpl::ProcessStartupURLs(
- const std::vector<GURL>& urls_to_open,
- chrome::HostDesktopType desktop_type) {
+ const std::vector<GURL>& urls_to_open) {
VLOG(1) << "StartupBrowserCreatorImpl::ProcessStartupURLs";
SessionStartupPref pref =
StartupBrowserCreator::GetSessionStartupPref(command_line_, profile_);
@@ -635,7 +630,7 @@ bool StartupBrowserCreatorImpl::ProcessStartupURLs(
return true;
}
- Browser* browser = ProcessSpecifiedURLs(urls_to_open, desktop_type);
+ Browser* browser = ProcessSpecifiedURLs(urls_to_open);
if (!browser)
return false;
@@ -654,8 +649,7 @@ bool StartupBrowserCreatorImpl::ProcessStartupURLs(
}
Browser* StartupBrowserCreatorImpl::ProcessSpecifiedURLs(
- const std::vector<GURL>& urls_to_open,
- chrome::HostDesktopType desktop_type) {
+ const std::vector<GURL>& urls_to_open) {
SessionStartupPref pref =
StartupBrowserCreator::GetSessionStartupPref(command_line_, profile_);
StartupTabs tabs;
@@ -695,7 +689,7 @@ Browser* StartupBrowserCreatorImpl::ProcessSpecifiedURLs(
if (tabs.empty())
return NULL;
- Browser* browser = OpenTabsInBrowser(NULL, true, tabs, desktop_type);
+ Browser* browser = OpenTabsInBrowser(NULL, true, tabs);
return browser;
}
@@ -722,18 +716,15 @@ void StartupBrowserCreatorImpl::AddUniqueURLs(const std::vector<GURL>& urls,
Browser* StartupBrowserCreatorImpl::OpenURLsInBrowser(
Browser* browser,
bool process_startup,
- const std::vector<GURL>& urls,
- chrome::HostDesktopType desktop_type) {
+ const std::vector<GURL>& urls) {
StartupTabs tabs;
UrlsToTabs(urls, &tabs);
- return OpenTabsInBrowser(browser, process_startup, tabs, desktop_type);
+ return OpenTabsInBrowser(browser, process_startup, tabs);
}
-Browser* StartupBrowserCreatorImpl::OpenTabsInBrowser(
- Browser* browser,
- bool process_startup,
- const StartupTabs& tabs,
- chrome::HostDesktopType desktop_type) {
+Browser* StartupBrowserCreatorImpl::OpenTabsInBrowser(Browser* browser,
+ bool process_startup,
+ const StartupTabs& tabs) {
DCHECK(!tabs.empty());
// If we don't yet have a profile, try to use the one we're given from

Powered by Google App Engine
This is Rietveld 408576698