Refactor ProfileInfoCache in c/b/ui/views

chrome/browser/profiles/avatar_menu.cc

Index: chrome/browser/profiles/avatar_menu.cc
diff --git a/chrome/browser/profiles/avatar_menu.cc b/chrome/browser/profiles/avatar_menu.cc
index 44ddd789b3987e6503b931e083c0276cbe4d1fb0..3f4ebd27b2597b81679cab0b8ac146880e2b7821 100644
--- a/chrome/browser/profiles/avatar_menu.cc
+++ b/chrome/browser/profiles/avatar_menu.cc
@@ -40,15 +40,17 @@
 
 using content::BrowserThread;
 
-AvatarMenu::AvatarMenu(ProfileInfoInterface* profile_cache,
+AvatarMenu::AvatarMenu(ProfileAttributesStorage* /*profile_storage*/,

[anthonyvd, 2016/02/19 15:09:07]

Can you file a bug about this follow up refactor so we don't forget about it?
Thanks!

[lwchkg, 2016/02/19 16:46:03]

As long as there is the word "ProfileInfoCache" in the source file we cannot
forget about it. All files with the word "ProfileInfoCache" are revealed by code
search, meaning the file is not properly refactored.

                        AvatarMenuObserver* observer,
                        Browser* browser)
-    : profile_list_(ProfileList::Create(profile_cache)),
+    : profile_list_(ProfileList::Create(
+          &g_browser_process->profile_manager()->GetProfileInfoCache())),

[Mike Lerman, 2016/02/19 15:08:12]

Would it be possible to move ProfileList into using the ProfileAttributesStorage
at this time? Or at least "soon" in an upcoming CL?

[lwchkg, 2016/02/19 16:46:03]

Definitely will be soon.

Anyway, I don't update the code now because this file is not in the directory
I'm targeting. (If it do this it looks like I need to add an extra 10-20 files
in the CL, and that make things complicated.)

       menu_actions_(AvatarMenuActions::Create()),
 #if defined(ENABLE_SUPERVISED_USERS)
       supervised_user_observer_(this),
 #endif
-      profile_info_(profile_cache),
+      profile_info_(
+          &g_browser_process->profile_manager()->GetProfileInfoCache()),
       observer_(observer),
       browser_(browser) {
   DCHECK(profile_info_);