Refactor ProfileInfoCache in c/b/ui/views

chrome/browser/ui/views/frame/browser_non_client_frame_view.cc

Index: chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
index c44d589408f9452d3fc4ea6f093d5ca054ef080c..2d42fafb877f7ff40e7295e198575b0c76b6cf9e 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
@@ -9,7 +9,6 @@
 #include "chrome/browser/profiles/avatar_menu.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
-#include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/themes/theme_properties.h"
@@ -38,18 +37,16 @@ BrowserNonClientFrameView::BrowserNonClientFrameView(BrowserFrame* frame,
       avatar_button_(nullptr) {

[achuithb, 2016/02/19 11:55:22]

nit: initialize this in header

[lwchkg, 2016/02/19 15:00:10]

Normally your suggestion is the better solution. But the #if section is a some
corner cases in styling, which Google C++ style fails to do well. Anyway here is
my suggestion of the indents. WDYT?

BrowserNonClientFrameView::BrowserNonClientFrameView(BrowserFrame* frame,
                                                     BrowserView* browser_view)
    : frame_(frame)
    , browser_view_(browser_view)
#if defined(FRAME_AVATAR_BUTTON)	
    , profile_switcher_(this)	  
#endif
{	  

P.S. I'll put this question the mailing list, so more people can give feedbacks.

[achuithb, 2016/02/19 15:06:18]

Personally I'm fine with this provided you leave a comment, but maybe someone
has a better idea. Maybe you can see what git cl format does with this?

[lwchkg, 2016/02/19 16:46:04]

Appears that someone has patched away the #if block. So I don't need to take
care of the punctuation now... (P.S. Anyway... rebase time.)

   // The profile manager may by null in tests.
   if (g_browser_process->profile_manager()) {
-    ProfileInfoCache& cache =
-        g_browser_process->profile_manager()->GetProfileInfoCache();
-    cache.AddObserver(this);
+    g_browser_process->profile_manager()->
+        GetProfileAttributesStorage().AddObserver(this);
   }
 }
 
 BrowserNonClientFrameView::~BrowserNonClientFrameView() {
   // The profile manager may by null in tests.
   if (g_browser_process->profile_manager()) {
-    ProfileInfoCache& cache =
-        g_browser_process->profile_manager()->GetProfileInfoCache();
-    cache.RemoveObserver(this);
+    g_browser_process->profile_manager()->
+        GetProfileAttributesStorage().RemoveObserver(this);
   }
 }
 
@@ -259,9 +256,9 @@ void BrowserNonClientFrameView::UpdateTaskbarDecoration() {
     // In tests, make sure that the browser process and profile manager are
     // valid before using.
     if (g_browser_process && g_browser_process->profile_manager()) {
-      const ProfileInfoCache& cache =
-          g_browser_process->profile_manager()->GetProfileInfoCache();
-      show_decoration = show_decoration && cache.GetNumberOfProfiles() > 1;
+      const ProfileAttributesStorage& storage =
+          g_browser_process->profile_manager()->GetProfileAttributesStorage();
+      show_decoration = show_decoration && storage.GetNumberOfProfiles() > 1;
     }
     chrome::DrawTaskbarDecoration(frame_->GetNativeWindow(),
         show_decoration