Refactor ProfileInfoCache in c/b/ui/views

chrome/browser/profiles/avatar_menu.h

Index: chrome/browser/profiles/avatar_menu.h
diff --git a/chrome/browser/profiles/avatar_menu.h b/chrome/browser/profiles/avatar_menu.h
index 6b420a020fd21c25873620687ee8b0b715500105..1117ba372b8d1292ed63c12d4407438e8d58df3b 100644
--- a/chrome/browser/profiles/avatar_menu.h
+++ b/chrome/browser/profiles/avatar_menu.h
@@ -29,6 +29,7 @@ class AvatarMenuActions;
 class AvatarMenuObserver;
 class Browser;
 class Profile;
+class ProfileAttributesStorage;
 class ProfileInfoInterface;
 class ProfileList;
 class SupervisedUserService;
@@ -90,7 +91,7 @@ class AvatarMenu :
 
   // Constructor. |observer| can be NULL. |browser| can be NULL and a new one
   // will be created if an action requires it.
-  AvatarMenu(ProfileInfoInterface* profile_cache,
+  AvatarMenu(ProfileAttributesStorage* /*profile_storage*/,

[Mike Lerman, 2016/02/19 15:08:12]

Wait... why aren't you giving a name to the first variable? Even if you're not
using it, you can still name it.

[lwchkg, 2016/02/19 16:46:04]

AFAIK this results in a compiler warning (which is treated as errors.) Anyway, I
forgot which compiler generates the warning. Will try and see after rebasing and
recompiling, which should take me a couple of hours.

[lwchkg, 2016/02/20 05:20:03]

No compile failures. I was too paranoid.

              AvatarMenuObserver* observer,
              Browser* browser);
   ~AvatarMenu() override;