Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1700993002: Remove strong mode support from property loads. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com, oth, rmcilroy, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove strong mode support from property loads. R=rossberg@chromium.org,bmeurer@chromium.org,verwaest@chromium.org BUG=v8:3956 LOG=n Committed: https://crrev.com/305a36e0d41f22d79b60daea70050e58f960bd8e Cr-Commit-Position: refs/heads/master@{#34067}

Patch Set 1 #

Patch Set 2 : Fix some issues. #

Patch Set 3 : Disable tests. #

Patch Set 4 : Ported to all architectures. #

Patch Set 5 : More fixes. #

Total comments: 2

Patch Set 6 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+606 lines, -1391 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/builtins.cc View 6 chunks +10 lines, -31 lines 0 comments Download
M src/code-factory.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/code-factory.cc View 1 chunk +10 lines, -18 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 3 chunks +10 lines, -58 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 5 chunks +14 lines, -20 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 6 chunks +5 lines, -17 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 7 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 7 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 5 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 7 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 8 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 7 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 7 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 5 chunks +2 lines, -8 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 2 3 8 chunks +12 lines, -28 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 2 3 4 9 chunks +14 lines, -32 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 2 3 11 chunks +12 lines, -27 lines 0 comments Download
M src/ic/ic.h View 5 chunks +9 lines, -22 lines 0 comments Download
M src/ic/ic.cc View 10 chunks +15 lines, -27 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/ic-state.h View 1 chunk +3 lines, -17 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 2 3 8 chunks +12 lines, -28 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 2 3 8 chunks +12 lines, -27 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 2 3 8 chunks +12 lines, -28 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 11 chunks +12 lines, -27 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 2 3 11 chunks +12 lines, -27 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 3 chunks +3 lines, -9 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 7 chunks +21 lines, -80 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 4 5 8 chunks +12 lines, -19 lines 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +8 lines, -18 lines 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +36 lines, -133 lines 0 comments Download
M src/objects.h View 5 chunks +10 lines, -17 lines 0 comments Download
M src/objects.cc View 11 chunks +14 lines, -34 lines 0 comments Download
M src/objects-inl.h View 3 chunks +10 lines, -19 lines 0 comments Download
M src/runtime/runtime.h View 1 3 chunks +3 lines, -6 lines 0 comments Download
M src/runtime/runtime-classes.cc View 5 chunks +15 lines, -28 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 5 chunks +6 lines, -43 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 61 chunks +84 lines, -224 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 4 chunks +59 lines, -71 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 3 chunks +8 lines, -19 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
rmcilroy
Interpreter changes lgtm once bots are happy.
4 years, 10 months ago (2016-02-16 15:04:54 UTC) #2
rmcilroy
Still lgtm. https://codereview.chromium.org/1700993002/diff/80001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): https://codereview.chromium.org/1700993002/diff/80001/src/interpreter/bytecode-generator.cc#newcode1867 src/interpreter/bytecode-generator.cc:1867: // TODO(oth): Abstraction not suitable for 3 ...
4 years, 10 months ago (2016-02-16 17:08:42 UTC) #6
Michael Starzinger
https://codereview.chromium.org/1700993002/diff/80001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): https://codereview.chromium.org/1700993002/diff/80001/src/interpreter/bytecode-generator.cc#newcode1867 src/interpreter/bytecode-generator.cc:1867: // TODO(oth): Abstraction not suitable for 3 args, will ...
4 years, 10 months ago (2016-02-16 17:13:17 UTC) #7
Michael Starzinger
This is ready for review. Andreas: Please sign off on the whole change. Benedikt: PTAL ...
4 years, 10 months ago (2016-02-16 17:14:23 UTC) #8
rossberg
lgtm (timbre)
4 years, 10 months ago (2016-02-16 17:31:07 UTC) #9
Toon Verwaest
So much yes! Land it before it conflicts with someone else ;-) LGTM
4 years, 10 months ago (2016-02-17 09:00:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700993002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700993002/100001
4 years, 10 months ago (2016-02-17 10:24:20 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-17 10:30:20 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 10:30:56 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/305a36e0d41f22d79b60daea70050e58f960bd8e
Cr-Commit-Position: refs/heads/master@{#34067}

Powered by Google App Engine
This is Rietveld 408576698