Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1700993002: Remove strong mode support from property loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-graph-builder.cc
diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc
index 35eee9fbffcda48fb1340a63196c510e1d3589fa..741dc8cd7f1edacb4aec4a9e7dcd91b3bfb70d90 100644
--- a/src/compiler/bytecode-graph-builder.cc
+++ b/src/compiler/bytecode-graph-builder.cc
@@ -645,35 +645,19 @@ void BytecodeGraphBuilder::BuildLoadGlobal(
environment()->BindAccumulator(node, &states);
}
-void BytecodeGraphBuilder::VisitLdaGlobalSloppy() {
+void BytecodeGraphBuilder::VisitLdaGlobal() {
BuildLoadGlobal(TypeofMode::NOT_INSIDE_TYPEOF);
}
-void BytecodeGraphBuilder::VisitLdaGlobalStrict() {
- BuildLoadGlobal(TypeofMode::NOT_INSIDE_TYPEOF);
-}
-
-void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofSloppy() {
- BuildLoadGlobal(TypeofMode::INSIDE_TYPEOF);
-}
-
-void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofStrict() {
+void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeof() {
BuildLoadGlobal(TypeofMode::INSIDE_TYPEOF);
}
-void BytecodeGraphBuilder::VisitLdaGlobalSloppyWide() {
+void BytecodeGraphBuilder::VisitLdaGlobalWide() {
BuildLoadGlobal(TypeofMode::NOT_INSIDE_TYPEOF);
}
-void BytecodeGraphBuilder::VisitLdaGlobalStrictWide() {
- BuildLoadGlobal(TypeofMode::NOT_INSIDE_TYPEOF);
-}
-
-void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofSloppyWide() {
- BuildLoadGlobal(TypeofMode::INSIDE_TYPEOF);
-}
-
-void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofStrictWide() {
+void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofWide() {
BuildLoadGlobal(TypeofMode::INSIDE_TYPEOF);
}
@@ -800,30 +784,14 @@ void BytecodeGraphBuilder::BuildNamedLoad() {
VectorSlotPair feedback =
CreateVectorSlotPair(bytecode_iterator().GetIndexOperand(2));
- const Operator* op = javascript()->LoadNamed(language_mode(), name, feedback);
+ const Operator* op = javascript()->LoadNamed(name, feedback);
Node* node = NewNode(op, object, GetFunctionClosure());
environment()->BindAccumulator(node, &states);
}
-void BytecodeGraphBuilder::VisitLoadICSloppy() {
- DCHECK(is_sloppy(language_mode()));
- BuildNamedLoad();
-}
-
-void BytecodeGraphBuilder::VisitLoadICStrict() {
- DCHECK(is_strict(language_mode()));
- BuildNamedLoad();
-}
+void BytecodeGraphBuilder::VisitLoadIC() { BuildNamedLoad(); }
-void BytecodeGraphBuilder::VisitLoadICSloppyWide() {
- DCHECK(is_sloppy(language_mode()));
- BuildNamedLoad();
-}
-
-void BytecodeGraphBuilder::VisitLoadICStrictWide() {
- DCHECK(is_strict(language_mode()));
- BuildNamedLoad();
-}
+void BytecodeGraphBuilder::VisitLoadICWide() { BuildNamedLoad(); }
void BytecodeGraphBuilder::BuildKeyedLoad() {
FrameStateBeforeAndAfter states(this);
@@ -833,30 +801,14 @@ void BytecodeGraphBuilder::BuildKeyedLoad() {
VectorSlotPair feedback =
CreateVectorSlotPair(bytecode_iterator().GetIndexOperand(1));
- const Operator* op = javascript()->LoadProperty(language_mode(), feedback);
+ const Operator* op = javascript()->LoadProperty(feedback);
Node* node = NewNode(op, object, key, GetFunctionClosure());
environment()->BindAccumulator(node, &states);
}
-void BytecodeGraphBuilder::VisitKeyedLoadICSloppy() {
- DCHECK(is_sloppy(language_mode()));
- BuildKeyedLoad();
-}
-
-void BytecodeGraphBuilder::VisitKeyedLoadICStrict() {
- DCHECK(is_strict(language_mode()));
- BuildKeyedLoad();
-}
+void BytecodeGraphBuilder::VisitKeyedLoadIC() { BuildKeyedLoad(); }
-void BytecodeGraphBuilder::VisitKeyedLoadICSloppyWide() {
- DCHECK(is_sloppy(language_mode()));
- BuildKeyedLoad();
-}
-
-void BytecodeGraphBuilder::VisitKeyedLoadICStrictWide() {
- DCHECK(is_strict(language_mode()));
- BuildKeyedLoad();
-}
+void BytecodeGraphBuilder::VisitKeyedLoadICWide() { BuildKeyedLoad(); }
void BytecodeGraphBuilder::BuildNamedStore(LanguageMode language_mode) {
FrameStateBeforeAndAfter states(this);
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698