Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1709493002: [turbofan] Remove language mode from JSCall operator. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_strong-remove-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove language mode from JSCall operator. This removes the language mode parameter from all JSCall operators. The information is no longer used anywhere and is not threaded through the interpreter bytecode. We should only thread it through the bytecode if it has a semantic impact on the compilation. R=bmeurer@chromium.org Committed: https://crrev.com/ef5ee8e1fdb2a094840541424fddc8d2042e2153 Cr-Commit-Position: refs/heads/master@{#34073}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -139 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M src/compiler/js-operator.h View 3 chunks +4 lines, -11 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 6 chunks +45 lines, -64 lines 0 comments Download
M test/unittests/compiler/js-context-relaxation-unittest.cc View 10 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-17 08:58:23 UTC) #1
Benedikt Meurer (Google)
LGTM!
4 years, 10 months ago (2016-02-17 10:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709493002/20001
4 years, 10 months ago (2016-02-17 11:52:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 12:04:24 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 12:04:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef5ee8e1fdb2a094840541424fddc8d2042e2153
Cr-Commit-Position: refs/heads/master@{#34073}

Powered by Google App Engine
This is Rietveld 408576698