Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: components/safe_browsing_db/database_manager.h

Issue 1700943003: SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix BUILD file Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/database_manager.h
diff --git a/components/safe_browsing_db/database_manager.h b/components/safe_browsing_db/database_manager.h
index 4924cacb32503fd883bdb906f0c620691e6205af..ea35855ea3f15be6c2101da75f8a435710cbc067 100644
--- a/components/safe_browsing_db/database_manager.h
+++ b/components/safe_browsing_db/database_manager.h
@@ -20,8 +20,15 @@
#include "content/public/common/resource_type.h"
#include "url/gurl.h"
+namespace net {
+class URLRequestContextGetter;
+} // namespace net
+
namespace safe_browsing {
+struct V4GetHashProtocolConfig;
+class V4GetHashProtocolManager;
+
// Base class to either the locally-managed or a remotely-managed database.
class SafeBrowsingDatabaseManager
: public base::RefCountedThreadSafe<SafeBrowsingDatabaseManager> {
@@ -146,9 +153,15 @@ class SafeBrowsingDatabaseManager
virtual void StopOnIOThread(bool shutdown) = 0;
protected:
- virtual ~SafeBrowsingDatabaseManager() {}
+ SafeBrowsingDatabaseManager();
+ SafeBrowsingDatabaseManager(
+ net::URLRequestContextGetter* request_context_getter,
+ const V4GetHashProtocolConfig& config);
+ virtual ~SafeBrowsingDatabaseManager();
friend class base::RefCountedThreadSafe<SafeBrowsingDatabaseManager>;
+
+ std::unique_ptr<V4GetHashProtocolManager> v4_get_hash_protocol_manager_;
Nathan Parker 2016/02/17 15:53:28 Hmm, didn't know we were using unique_ptr's (rathe
kcarattini 2016/02/18 02:55:29 Acknowledged.
}; // class SafeBrowsingDatabaseManager
} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698