SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager

components/safe_browsing_db/database_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The Safe Browsing service is responsible for downloading anti-phishing and
 // anti-malware tables and checking urls against them.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_DATABASE_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_DB_DATABASE_MANAGER_H_
 
 #include <deque>
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "components/safe_browsing_db/hit_report.h"
 #include "components/safe_browsing_db/util.h"
 #include "content/public/common/resource_type.h"
 #include "url/gurl.h"
 
+namespace net {
+class URLRequestContextGetter;
+}  // namespace net
+
 namespace safe_browsing {
 
+struct V4GetHashProtocolConfig;
+class V4GetHashProtocolManager;
+
 // Base class to either the locally-managed or a remotely-managed database.
 class SafeBrowsingDatabaseManager
     : public base::RefCountedThreadSafe<SafeBrowsingDatabaseManager> {
  public:
   // Callers requesting a result should derive from this class.
   // The destructor should call db_manager->CancelCheck(client) if a
   // request is still pending.
   class Client {
    public:
     virtual ~Client() {}
@@ skipping 104 matching lines @@
   // called multiple times during the life of the DatabaseManager. Must be
   // called on IO thread.
   virtual void StartOnIOThread() = 0;
 
   // Called to stop or shutdown operations on the io_thread. This may be called
   // multiple times during the life of the DatabaseManager. Must be called
   // on IO thread. If shutdown is true, the manager is disabled permanently.
   virtual void StopOnIOThread(bool shutdown) = 0;
 
  protected:
-  virtual ~SafeBrowsingDatabaseManager() {}
+  SafeBrowsingDatabaseManager();
+  SafeBrowsingDatabaseManager(
+      net::URLRequestContextGetter* request_context_getter,
+      const V4GetHashProtocolConfig& config);
+  virtual ~SafeBrowsingDatabaseManager();
 
   friend class base::RefCountedThreadSafe<SafeBrowsingDatabaseManager>;
+
+  std::unique_ptr<V4GetHashProtocolManager> v4_get_hash_protocol_manager_;

[Nathan Parker, 2016/02/17 15:53:28]

Hmm, didn't know we were using unique_ptr's (rather than scoped_ptr), but this
bug implies that's the desire:
https://code.google.com/p/chromium/issues/detail?id=554298.  sgtm.

[kcarattini, 2016/02/18 02:55:29]

Acknowledged.

 };  // class SafeBrowsingDatabaseManager
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_DATABASE_MANAGER_H_