SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager

chrome/browser/safe_browsing/safe_browsing_service.h

Index: chrome/browser/safe_browsing/safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h
index ec8d59c98b0846bdbb1a06fe4aa4af1a564bd4e3..3c3435dd095b7ffe30a700c6a0307b5f4abf4919 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/safe_browsing_service.h
@@ -58,6 +58,7 @@ class SafeBrowsingProtocolManagerDelegate;
 class SafeBrowsingServiceFactory;
 class SafeBrowsingUIManager;
 class SafeBrowsingURLRequestContextGetter;
+struct V4GetHashProtocolConfig;
 
 #if defined(FULL_SAFE_BROWSING)
 class IncidentReportingService;
@@ -103,6 +104,12 @@ class SafeBrowsingService
   // Create a protocol config struct.
   virtual SafeBrowsingProtocolConfig GetProtocolConfig() const;

[Nathan Parker, 2016/02/17 15:53:28]

Do these need to be public?

[kcarattini, 2016/02/18 02:55:29]

Turns out yes -- blacklist_state_fetcher calls it.

 
+  // Create a v4 protocol config struct.
+  virtual V4GetHashProtocolConfig GetV4GetHashProtocolConfig() const;

[Nathan Parker, 2016/02/17 15:53:28]

I probably missed this before... but would this be better as
"V4ProtocolConfig()", so it can be shared between get full hash code and update
code?

I realize I'm adding lots of constraints for steering this towards future
compatibility, but these changes will make it a lot cleaner later.  Thank you!

[kcarattini, 2016/02/17 22:44:42]

I figured the Update config would need a lot more than the GetHash config which
is why I separated them.  If you prefer to use the same one, I'll rename and
move to util.cc in a followup cl.

+
+  // Returns the client_name field for both V3 and V4 protocol manager configs.
+  std::string GetProtocolConfigClientName() const;
+
   // Get current enabled status. Must be called on IO thread.
   bool enabled() const {
     DCHECK_CURRENTLY_ON(content::BrowserThread::IO);