SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager

chrome/browser/safe_browsing/local_database_manager.h

Index: chrome/browser/safe_browsing/local_database_manager.h
diff --git a/chrome/browser/safe_browsing/local_database_manager.h b/chrome/browser/safe_browsing/local_database_manager.h
index fd9712ba935e37c89ad8d05d0b901034906ce964..da58ea1e542819ebe32b87ddcdf2bf767af8af57 100644
--- a/chrome/browser/safe_browsing/local_database_manager.h
+++ b/chrome/browser/safe_browsing/local_database_manager.h
@@ -41,6 +41,7 @@ class SafeBrowsingService;
 class SafeBrowsingDatabase;
 class ClientSideDetectionService;
 class DownloadProtectionService;
+struct V4GetHashProtocolConfig;
 
 // Implemetation that manages a local database on disk.
 //
@@ -100,6 +101,11 @@ class LocalSafeBrowsingDatabaseManager
   explicit LocalSafeBrowsingDatabaseManager(

[Nathan Parker, 2016/02/17 15:53:27]

Can we get rid of the other constructor yet, to ensure we don't miss some cases?
Or do you want to leave it for simplicity?  If the latter, maybe it should be
just for testing.

[kcarattini, 2016/02/17 22:44:42]

I think having two is simpler so I don't have to go change all the tests. I'll
add a comment that this is just for testing. Plus I get to use C++11's fancy new
constructor delegation! :)

[kcarattini, 2016/02/18 02:55:29]

Done.

       const scoped_refptr<SafeBrowsingService>& service);
 
+  LocalSafeBrowsingDatabaseManager(
+      const scoped_refptr<SafeBrowsingService>& service,
+      net::URLRequestContextGetter* request_context_getter,
+      const V4GetHashProtocolConfig& config);
+
   //
   // SafeBrowsingDatabaseManager overrides
   //