SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager

chrome/browser/safe_browsing/local_database_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Safe Browsing Database Manager implementation that manages a local
 // database.  This is used by Desktop Chromium.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_LOCAL_DATABASE_MANAGER_H_
 #define CHROME_BROWSER_SAFE_BROWSING_LOCAL_DATABASE_MANAGER_H_
 
@@ skipping 23 matching lines @@
 class URLRequestContext;
 class URLRequestContextGetter;
 }
 
 namespace safe_browsing {
 
 class SafeBrowsingService;
 class SafeBrowsingDatabase;
 class ClientSideDetectionService;
 class DownloadProtectionService;
+struct V4GetHashProtocolConfig;
 
 // Implemetation that manages a local database on disk.
 //
 // Construction needs to happen on the main thread.
 class LocalSafeBrowsingDatabaseManager
     : public SafeBrowsingDatabaseManager,
       public SafeBrowsingProtocolManagerDelegate {
  public:
   // Bundle of SafeBrowsing state while performing a URL or hash prefix check.
   struct SafeBrowsingCheck {
@@ skipping 36 matching lines @@
     // for browsing too (instead of implementing in
     // safe_browsing_resource_handler.cc).
     scoped_ptr<base::WeakPtrFactory<LocalSafeBrowsingDatabaseManager>>
         weak_ptr_factory_;
 
    private:
     DISALLOW_COPY_AND_ASSIGN(SafeBrowsingCheck);
   };
 
   // Creates the safe browsing service.  Need to initialize before using.
   explicit LocalSafeBrowsingDatabaseManager(

[Nathan Parker, 2016/02/17 15:53:27]

Can we get rid of the other constructor yet, to ensure we don't miss some cases?
Or do you want to leave it for simplicity?  If the latter, maybe it should be
just for testing.

[kcarattini, 2016/02/17 22:44:42]

I think having two is simpler so I don't have to go change all the tests. I'll
add a comment that this is just for testing. Plus I get to use C++11's fancy new
constructor delegation! :)

[kcarattini, 2016/02/18 02:55:29]

Done.

       const scoped_refptr<SafeBrowsingService>& service);
 
+  LocalSafeBrowsingDatabaseManager(
+      const scoped_refptr<SafeBrowsingService>& service,
+      net::URLRequestContextGetter* request_context_getter,
+      const V4GetHashProtocolConfig& config);
+
   //
   // SafeBrowsingDatabaseManager overrides
   //
 
   bool IsSupported() const override;
   safe_browsing::ThreatSource GetThreatSource() const override;
   bool ChecksAreAlwaysAsync() const override;
   bool CanCheckResourceType(content::ResourceType resource_type) const override;
   bool CanCheckUrl(const GURL& url) const override;
 
@@ skipping 249 matching lines @@
 
   // Timeout to use for safe browsing checks.
   base::TimeDelta check_timeout_;
 
   DISALLOW_COPY_AND_ASSIGN(LocalSafeBrowsingDatabaseManager);
 };  // class LocalSafeBrowsingDatabaseManager
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_LOCAL_DATABASE_MANAGER_H_