Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1700873002: Remove HostDesktopType from task manager (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-25
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from task manager R=sky@chromium.org BUG=558054 Committed: https://crrev.com/34e29d4fd4eca093d6e0fb09288488d284e64099 Cr-Commit-Position: refs/heads/master@{#376104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -35 lines) Patch
M chrome/browser/task_manager/task_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.h View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.cc View 5 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 5 chunks +5 lines, -15 lines 0 comments Download

Depends on Patchset:

Issue 1701793002 Patch 1

Dependent Patchsets:

Issue 1697243002 Patch 1
Issue 1697243002 Patch 20001

Messages

Total messages: 7 (2 generated)
scottmg
Oops, forgot to mail this one.
4 years, 10 months ago (2016-02-17 18:59:11 UTC) #1
sky
LGTM
4 years, 10 months ago (2016-02-17 20:37:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700873002/1
4 years, 10 months ago (2016-02-18 05:14:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 06:18:48 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 06:19:56 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/34e29d4fd4eca093d6e0fb09288488d284e64099
Cr-Commit-Position: refs/heads/master@{#376104}

Powered by Google App Engine
This is Rietveld 408576698