Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697243002: Remove HostDesktopType from window_finder (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-26
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from window_finder R=sky@chromium.org BUG=558054 Committed: https://crrev.com/93954304f1188bc0945afff9e3a888d4e6879eaf Cr-Commit-Position: refs/heads/master@{#376110}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 2 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_x11.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Depends on Patchset:

Issue 1700873002 Patch 1

Dependent Patchsets:

Issue 1694333002 Patch 1

Messages

Total messages: 7 (2 generated)
scottmg
4 years, 10 months ago (2016-02-15 23:13:55 UTC) #1
sky
LGTM
4 years, 10 months ago (2016-02-16 03:01:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697243002/20001
4 years, 10 months ago (2016-02-18 06:26:19 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 07:07:30 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 07:08:53 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/93954304f1188bc0945afff9e3a888d4e6879eaf
Cr-Commit-Position: refs/heads/master@{#376110}

Powered by Google App Engine
This is Rietveld 408576698