Port BrowsingDataDatabaseHelper to webkit_database::DatabaseIdentifier

Port BrowsingDataDatabaseHelper to webkit_database::DatabaseIdentifier

This avoids a hop over to the webkit thread to construct an origin identifier and
a dependency on third_party/WebKit for WebSecurityOrigin.

R=michaeln
BUG=237267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207555

[jamesr, 2013-06-19 22:11:10]

https://codereview.chromium.org/17003010/diff/1/webkit/common/database/databa...
File webkit/common/database/database_identifier.h (right):

https://codereview.chromium.org/17003010/diff/1/webkit/common/database/databa...
webkit/common/database/database_identifier.h:5: #ifndef
WEBKIT_COMMON_DATABASE_DATABASE_IDENTIFIER_H_
this is a big whoopsie - I got lucky since there were no #includes of this from
other headers before.  D'oh!

[jamesr, 2013-06-19 22:12:48]

https://codereview.chromium.org/17003010/diff/1/chrome/browser/browsing_data/...
File chrome/browser/browsing_data/browsing_data_database_helper.cc (right):

https://codereview.chromium.org/17003010/diff/1/chrome/browser/browsing_data/...
chrome/browser/browsing_data/browsing_data_database_helper.cc:217:
BrowserThread::PostTask(
this still PostTask()s to its own thread just to keep StartFetching
asynchronous.  I'm not sure this is really necessary - we can construct a
DatabaseInfo set from origins directly on the UI thread.  Since
CannedBrowsingDataDatabaseHelper is a subclass of BDDH, which has to do
StartFetching() asynchronously since it touches the file thread, it wasn't
totally clear if this could just be nuked.

[michaeln, 2013-06-19 23:28:29]

lgtm

https://codereview.chromium.org/17003010/diff/1/chrome/browser/browsing_data/...
File chrome/browser/browsing_data/browsing_data_database_helper.cc (left):

https://codereview.chromium.org/17003010/diff/1/chrome/browser/browsing_data/...
chrome/browser/browsing_data/browsing_data_database_helper.cc:226:
WebSecurityOrigin::createFromString(
this was silly code, there was never really a need to do this work on the webkit
thread

https://codereview.chromium.org/17003010/diff/1/chrome/browser/browsing_data/...
File chrome/browser/browsing_data/browsing_data_database_helper.cc (right):

https://codereview.chromium.org/17003010/diff/1/chrome/browser/browsing_data/...
chrome/browser/browsing_data/browsing_data_database_helper.cc:217:
BrowserThread::PostTask(
On 2013/06/19 22:12:48, jamesr wrote:
> this still PostTask()s to its own thread just to keep StartFetching
> asynchronous.  I'm not sure this is really necessary - we can construct a
> DatabaseInfo set from origins directly on the UI thread.  Since
> CannedBrowsingDataDatabaseHelper is a subclass of BDDH, which has to do
> StartFetching() asynchronously since it touches the file thread, it wasn't
> totally clear if this could just be nuked.

we should keep the behavior async so this mock exhibits the same behavior

https://codereview.chromium.org/17003010/diff/1/webkit/common/database/databa...
File webkit/common/database/database_identifier.h (right):

https://codereview.chromium.org/17003010/diff/1/webkit/common/database/databa...
webkit/common/database/database_identifier.h:5: #ifndef
WEBKIT_COMMON_DATABASE_DATABASE_IDENTIFIER_H_
On 2013/06/19 22:11:10, jamesr wrote:
> this is a big whoopsie - I got lucky since there were no #includes of this
from
> other headers before.  D'oh!

whoa... does lint complain about this, or a presubmit warning, we have so many
nannytools one of them must have noticed :)

[commit-bot: I haz the power, 2013-06-20 01:48:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17003010/1

[commit-bot: I haz the power, 2013-06-20 04:23:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[jamesr, 2013-06-20 17:00:24]

Nico - could you take a look at
chrome/browser/ui/cocoa/content_settings/cookie_details_unittest.mm ?

[Nico, 2013-06-20 17:02:18]

cocoa lgtm

[commit-bot: I haz the power, 2013-06-20 17:07:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17003010/23001

[commit-bot: I haz the power, 2013-06-20 20:48:28]

Change committed as 207555