Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc

Issue 17003010: Port BrowsingDataDatabaseHelper to webkit_database::DatabaseIdentifier (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc b/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc
index d8a9642e50feb616a3cde7e92dca5284f78f4158..ab1ea67b3e4de40b4fcacd059aae3f49fce48834 100644
--- a/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc
+++ b/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc
@@ -71,7 +71,7 @@ class StopTestOnCallback {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
ASSERT_EQ(1UL, database_info_list.size());
EXPECT_EQ(std::string(kTestIdentifier1),
- database_info_list.begin()->origin_identifier);
+ database_info_list.begin()->identifier.ToString());
base::MessageLoop::current()->Quit();
}
@@ -117,13 +117,13 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataDatabaseHelperTest, CannedAddDatabase) {
ASSERT_EQ(3u, result.size());
std::list<BrowsingDataDatabaseHelper::DatabaseInfo>::iterator info =
result.begin();
- EXPECT_STREQ(origin_str1, info->origin_identifier.c_str());
+ EXPECT_EQ(origin_str1, info->identifier.ToString());
EXPECT_STREQ(db1, info->database_name.c_str());
info++;
- EXPECT_STREQ(origin_str1, info->origin_identifier.c_str());
+ EXPECT_EQ(origin_str1, info->identifier.ToString());
EXPECT_STREQ(db2, info->database_name.c_str());
info++;
- EXPECT_STREQ(origin_str2, info->origin_identifier.c_str());
+ EXPECT_EQ(origin_str2, info->identifier.ToString());
EXPECT_STREQ(db3, info->database_name.c_str());
}
@@ -146,7 +146,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataDatabaseHelperTest, CannedUnique) {
callback.result();
ASSERT_EQ(1u, result.size());
- EXPECT_STREQ(origin_str, result.begin()->origin_identifier.c_str());
+ EXPECT_EQ(origin_str, result.begin()->identifier.ToString());
EXPECT_STREQ(db, result.begin()->database_name.c_str());
}
} // namespace
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_database_helper.cc ('k') | chrome/browser/browsing_data/cookies_tree_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698