Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc

Issue 17003010: Port BrowsingDataDatabaseHelper to webkit_database::DatabaseIdentifier (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/bind_helpers.h" 6 #include "base/bind_helpers.h"
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/browsing_data/browsing_data_database_helper.h" 9 #include "chrome/browser/browsing_data/browsing_data_database_helper.h"
10 #include "chrome/browser/browsing_data/browsing_data_helper_browsertest.h" 10 #include "chrome/browser/browsing_data/browsing_data_helper_browsertest.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 BrowsingDataDatabaseHelper* database_helper) 64 BrowsingDataDatabaseHelper* database_helper)
65 : database_helper_(database_helper) { 65 : database_helper_(database_helper) {
66 DCHECK(database_helper_); 66 DCHECK(database_helper_);
67 } 67 }
68 68
69 void Callback(const std::list<BrowsingDataDatabaseHelper::DatabaseInfo>& 69 void Callback(const std::list<BrowsingDataDatabaseHelper::DatabaseInfo>&
70 database_info_list) { 70 database_info_list) {
71 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 71 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
72 ASSERT_EQ(1UL, database_info_list.size()); 72 ASSERT_EQ(1UL, database_info_list.size());
73 EXPECT_EQ(std::string(kTestIdentifier1), 73 EXPECT_EQ(std::string(kTestIdentifier1),
74 database_info_list.begin()->origin_identifier); 74 database_info_list.begin()->identifier.ToString());
75 base::MessageLoop::current()->Quit(); 75 base::MessageLoop::current()->Quit();
76 } 76 }
77 77
78 private: 78 private:
79 BrowsingDataDatabaseHelper* database_helper_; 79 BrowsingDataDatabaseHelper* database_helper_;
80 }; 80 };
81 81
82 // Flaky on Win/Mac/Linux: http://crbug.com/92460 82 // Flaky on Win/Mac/Linux: http://crbug.com/92460
83 IN_PROC_BROWSER_TEST_F(BrowsingDataDatabaseHelperTest, DISABLED_FetchData) { 83 IN_PROC_BROWSER_TEST_F(BrowsingDataDatabaseHelperTest, DISABLED_FetchData) {
84 CreateDatabases(); 84 CreateDatabases();
(...skipping 25 matching lines...) Expand all
110 helper->StartFetching( 110 helper->StartFetching(
111 base::Bind(&TestCompletionCallback::callback, 111 base::Bind(&TestCompletionCallback::callback,
112 base::Unretained(&callback))); 112 base::Unretained(&callback)));
113 113
114 std::list<BrowsingDataDatabaseHelper::DatabaseInfo> result = 114 std::list<BrowsingDataDatabaseHelper::DatabaseInfo> result =
115 callback.result(); 115 callback.result();
116 116
117 ASSERT_EQ(3u, result.size()); 117 ASSERT_EQ(3u, result.size());
118 std::list<BrowsingDataDatabaseHelper::DatabaseInfo>::iterator info = 118 std::list<BrowsingDataDatabaseHelper::DatabaseInfo>::iterator info =
119 result.begin(); 119 result.begin();
120 EXPECT_STREQ(origin_str1, info->origin_identifier.c_str()); 120 EXPECT_EQ(origin_str1, info->identifier.ToString());
121 EXPECT_STREQ(db1, info->database_name.c_str()); 121 EXPECT_STREQ(db1, info->database_name.c_str());
122 info++; 122 info++;
123 EXPECT_STREQ(origin_str1, info->origin_identifier.c_str()); 123 EXPECT_EQ(origin_str1, info->identifier.ToString());
124 EXPECT_STREQ(db2, info->database_name.c_str()); 124 EXPECT_STREQ(db2, info->database_name.c_str());
125 info++; 125 info++;
126 EXPECT_STREQ(origin_str2, info->origin_identifier.c_str()); 126 EXPECT_EQ(origin_str2, info->identifier.ToString());
127 EXPECT_STREQ(db3, info->database_name.c_str()); 127 EXPECT_STREQ(db3, info->database_name.c_str());
128 } 128 }
129 129
130 IN_PROC_BROWSER_TEST_F(BrowsingDataDatabaseHelperTest, CannedUnique) { 130 IN_PROC_BROWSER_TEST_F(BrowsingDataDatabaseHelperTest, CannedUnique) {
131 const GURL origin("http://host1:1/"); 131 const GURL origin("http://host1:1/");
132 const char origin_str[] = "http_host1_1"; 132 const char origin_str[] = "http_host1_1";
133 const char db[] = "db1"; 133 const char db[] = "db1";
134 134
135 scoped_refptr<CannedBrowsingDataDatabaseHelper> helper( 135 scoped_refptr<CannedBrowsingDataDatabaseHelper> helper(
136 new CannedBrowsingDataDatabaseHelper(browser()->profile())); 136 new CannedBrowsingDataDatabaseHelper(browser()->profile()));
137 helper->AddDatabase(origin, db, std::string()); 137 helper->AddDatabase(origin, db, std::string());
138 helper->AddDatabase(origin, db, std::string()); 138 helper->AddDatabase(origin, db, std::string());
139 139
140 TestCompletionCallback callback; 140 TestCompletionCallback callback;
141 helper->StartFetching( 141 helper->StartFetching(
142 base::Bind(&TestCompletionCallback::callback, 142 base::Bind(&TestCompletionCallback::callback,
143 base::Unretained(&callback))); 143 base::Unretained(&callback)));
144 144
145 std::list<BrowsingDataDatabaseHelper::DatabaseInfo> result = 145 std::list<BrowsingDataDatabaseHelper::DatabaseInfo> result =
146 callback.result(); 146 callback.result();
147 147
148 ASSERT_EQ(1u, result.size()); 148 ASSERT_EQ(1u, result.size());
149 EXPECT_STREQ(origin_str, result.begin()->origin_identifier.c_str()); 149 EXPECT_EQ(origin_str, result.begin()->identifier.ToString());
150 EXPECT_STREQ(db, result.begin()->database_name.c_str()); 150 EXPECT_STREQ(db, result.begin()->database_name.c_str());
151 } 151 }
152 } // namespace 152 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_database_helper.cc ('k') | chrome/browser/browsing_data/cookies_tree_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698