Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699073004: Delete GrTextContext (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@sever-the-cord
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -168 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 4 chunks +5 lines, -9 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 5 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D src/gpu/text/GrTextContext.h View 1 chunk +0 lines, -60 lines 0 comments Download
D src/gpu/text/GrTextContext.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M src/gpu/text/GrTextUtils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 5 chunks +47 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1701013002 Patch 40001

Messages

Total messages: 13 (8 generated)
joshualitt
with this, now the textcontexts can arbitrarily diverge as needed. Ptal.
4 years, 10 months ago (2016-02-16 16:29:12 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1699073004/diff/1/src/gpu/text/GrTextUtils.cpp File src/gpu/text/GrTextUtils.cpp (right): https://codereview.chromium.org/1699073004/diff/1/src/gpu/text/GrTextUtils.cpp#newcode539 src/gpu/text/GrTextUtils.cpp:539: bool GrTextUtils::ShouldDisableLCD(const SkPaint& paint) { Can we just ...
4 years, 10 months ago (2016-02-16 17:19:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699073004/20001
4 years, 10 months ago (2016-02-16 18:39:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699073004/20001
4 years, 10 months ago (2016-02-16 18:52:50 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 19:09:28 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8e84a1ed07ad5d529d381d43302e597f31723076

Powered by Google App Engine
This is Rietveld 408576698