Create GrPathRenderingDrawContext

Create GrPathRenderingDrawContext

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1701013002

Committed: https://skia.googlesource.com/skia/+/96880d9e366d58e5960aa0ee6aa67260797679eb

[joshua.litt, 2016-02-16 15:59:53]

Description was changed from

==========
Create GrPathRenderingDrawContext

BUG=skia:
==========

to

==========
Create GrPathRenderingDrawContext

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-02-16 16:01:10]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2016-02-16 16:01:10]

ptal

[robertphillips, 2016-02-16 17:05:11]

lgtm + nits

https://codereview.chromium.org/1701013002/diff/1/include/gpu/GrDrawContext.h
File include/gpu/GrDrawContext.h (right):

https://codereview.chromium.org/1701013002/diff/1/include/gpu/GrDrawContext.h...
include/gpu/GrDrawContext.h:318: GrDrawTarget*     fDrawTarget;
fAtlasTextContext ?

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
File src/gpu/GrPathRenderingDrawContext.cpp (right):

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
src/gpu/GrPathRenderingDrawContext.cpp:13: 
Do we need OWNED_RESOURCE ?

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
src/gpu/GrPathRenderingDrawContext.cpp:18: #define RETURN_IF_ABANDONED        if
(this->drawingManager()->abandoned()) { return; }
rm _FALSE & _NULL flavors ?

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
src/gpu/GrPathRenderingDrawContext.cpp:29: SkDEBUGCODE(this->validate();)
GrPathRenderingDrawContext:: ?

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
src/gpu/GrPathRenderingDrawContext.cpp:39: }
\n

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
src/gpu/GrPathRenderingDrawContext.cpp:48: SkDEBUGCODE(this->validate();)
GrPathRenderingDrawContext:: ?

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
src/gpu/GrPathRenderingDrawContext.cpp:58: }
\n

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
src/gpu/GrPathRenderingDrawContext.cpp:65: SkDEBUGCODE(this->validate();)
GrPathRenderingDrawContext:: ?

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
File src/gpu/GrPathRenderingDrawContext.h (right):

https://codereview.chromium.org/1701013002/diff/1/src/gpu/GrPathRenderingDraw...
src/gpu/GrPathRenderingDrawContext.h:35: private:
fStencilAndCoverTextContext ?

[joshualitt, 2016-02-16 17:40:35]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-02-16 17:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1701013002/#ps40001
(title: "tweaks")

[commit-bot: I haz the power, 2016-02-16 17:40:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701013002/40001

[commit-bot: I haz the power, 2016-02-16 17:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 17:41:54]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[joshualitt, 2016-02-16 17:43:19]

Description was changed from

==========
Create GrPathRenderingDrawContext

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Create GrPathRenderingDrawContext

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-02-16 18:35:51]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-02-16 18:35:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1701013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1701013002/40001

[commit-bot: I haz the power, 2016-02-16 18:36:55]

Description was changed from

==========
Create GrPathRenderingDrawContext

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Create GrPathRenderingDrawContext

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/96880d9e366d58e5960aa0ee6aa67260797679eb
==========

[commit-bot: I haz the power, 2016-02-16 18:36:55]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/96880d9e366d58e5960aa0ee6aa67260797679eb