Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1697843002: Provide angle_unittests_run independent of archive_gpu_tests. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide angle_unittests_run independent of archive_gpu_tests. https://codereview.chromium.org/457813002/ moved a bunch of tests running on the GPU waterfalls only behind archive_gpu_tests. However, angle_unittests runs on some non-GPU bots (and should run on many more to prevent issues like crbug.com/487341) and having angle_unittests_run be available unconditionally is a prerequisite for running them on swarming, which I'm doing in https://codereview.chromium.org/1690463003/. The try bots no longer build 'all', so the archive_gpu_tests thing is less important; also angle_unittests_run takes just 2 seconds to run on my laptop. BUG=98637, 401985 Committed: https://crrev.com/31a06c2f67771d0d77376b434d8d481d30bcd1ff Cr-Commit-Position: refs/heads/master@{#375373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Nico
first to stamp wins!
4 years, 10 months ago (2016-02-13 18:21:56 UTC) #3
Dirk Pranke
I'm punting this to Ken; I don't remember what the limitations for angle_unittests were offhand.
4 years, 10 months ago (2016-02-13 20:30:29 UTC) #4
Nico
On 2016/02/13 20:30:29, Dirk Pranke wrote: > I'm punting this to Ken; I don't remember ...
4 years, 10 months ago (2016-02-13 20:32:18 UTC) #5
Nico
On 2016/02/13 20:30:29, Dirk Pranke wrote: > I'm punting this to Ken; I don't remember ...
4 years, 10 months ago (2016-02-13 20:32:20 UTC) #6
Dirk Pranke
On 2016/02/13 20:32:20, Nico wrote: > On 2016/02/13 20:30:29, Dirk Pranke wrote: > > I'm ...
4 years, 10 months ago (2016-02-14 00:10:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697843002/1
4 years, 10 months ago (2016-02-14 00:41:06 UTC) #9
Nico
thanks!
4 years, 10 months ago (2016-02-14 00:41:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-14 00:45:50 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31a06c2f67771d0d77376b434d8d481d30bcd1ff Cr-Commit-Position: refs/heads/master@{#375373}
4 years, 10 months ago (2016-02-16 22:48:02 UTC) #14
Ken Russell (switch to Gerrit)
4 years, 10 months ago (2016-02-17 01:30:09 UTC) #15
Message was sent while issue was closed.
lgtm after the fact.

Powered by Google App Engine
This is Rietveld 408576698