Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1690463003: Run angle_unittests on swarming. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, Jamie Madill, Geoff Lang, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run angle_unittests on swarming. angle_unittests goes through all the motions to run on swarming (isolate file, angle_unittests_run target, etc), but it doesn't run on swarming anywhere. Since the test is pretty slow, move it to swarming. $ testing/buildbot/manage.py --convert angle_unittests Convert angle_unittests to run exclusively on Swarming 32 configs already ran on Swarming 31 used to run locally and were converted: - chromium.angle.json: Linux Tests (ANGLE) - chromium.angle.json: Linux Tests (dbg) (ANGLE) - chromium.angle.json: Mac10.8 Tests (ANGLE) - chromium.angle.json: Mac10.8 Tests (dbg) (ANGLE) - chromium.angle.json: Win7 Tests (ANGLE) - chromium.angle.json: Win7 Tests (dbg) (ANGLE) - chromium.angle.json: Win7 Tests x64 (ANGLE) - chromium.angle.json: Win7 Tests x64 (dbg) (ANGLE) - chromium.fyi.json: CFI Linux - chromium.fyi.json: Chromium Win 10 - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTLinuxUBSanVptr tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: CrWinAsanCov tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester Ran: ./manage.py --convert angle_unittests R= BUG=98637 Committed: https://crrev.com/12c5722b310f26d3c534e3979e34be1ccbb2a3d0 Cr-Commit-Position: refs/heads/master@{#375376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -0 lines) Patch
M testing/buildbot/chromium.angle.json View 8 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 23 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Nico
Does swarming work on the chromium.gpu waterfall?
4 years, 10 months ago (2016-02-10 20:41:00 UTC) #2
Ken Russell (switch to Gerrit)
On 2016/02/10 20:41:00, Nico wrote: > Does swarming work on the chromium.gpu waterfall? Yes. All ...
4 years, 10 months ago (2016-02-11 01:03:31 UTC) #4
Ken Russell (switch to Gerrit)
Also, lgtm.
4 years, 10 months ago (2016-02-11 01:03:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690463003/1
4 years, 10 months ago (2016-02-11 21:44:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 23:58:42 UTC) #9
Nico
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1693703002/ by thakis@chromium.org. ...
4 years, 10 months ago (2016-02-12 02:12:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690463003/1
4 years, 10 months ago (2016-02-14 00:47:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-14 02:35:07 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/947f2ffb08e7870d7d58e303288e5804b9adcc59 Cr-Commit-Position: refs/heads/master@{#375049}
4 years, 10 months ago (2016-02-16 22:39:44 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:48:06 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12c5722b310f26d3c534e3979e34be1ccbb2a3d0
Cr-Commit-Position: refs/heads/master@{#375376}

Powered by Google App Engine
This is Rietveld 408576698