Issue 169763003: Update dart2js diagnostics to prepare for filtering.

Issue 169763003: Update dart2js diagnostics to prepare for filtering. (Closed)

Created:
6 years, 10 months ago by Johnni Winther

Modified:
6 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clean up dart2js diagnostics to prepare for filtering. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32847

Patch Set 2 : Remove optional Uri. #

Total comments: 3

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -171 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/apiimpl.dart	View		3 chunks	+6 lines, -3 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	10 chunks	+35 lines, -44 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart2jslib.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart	View	1	1 chunk	+9 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		4 chunks	+6 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/class_members.dart	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		9 chunks	+16 lines, -30 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree_validator.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	tests/compiler/dart2js/compiler_test.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/exit_code_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View		3 chunks	+14 lines, -37 lines	0 comments	Download
M	tests/compiler/dart2js/parser_helper.dart	View	1	2 chunks	+5 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM with one comment. https://codereview.chromium.org/169763003/diff/20001/sdk/lib/_internal/compiler/implementation/apiimpl.dart File sdk/lib/_internal/compiler/implementation/apiimpl.dart (right): https://codereview.chromium.org/169763003/diff/20001/sdk/lib/_internal/compiler/implementation/apiimpl.dart#newcode289 sdk/lib/_internal/compiler/implementation/apiimpl.dart:289: leg.Diagnostic message, We really have ...

6 years, 10 months ago (2014-02-19 14:57:39 UTC) #2

Johnni Winther

Committed patchset #2 manually as r32847 (presubmit successful).

6 years, 10 months ago (2014-02-20 09:33:33 UTC) #3

Johnni Winther

6 years, 10 months ago (2014-02-20 09:35:39 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/169763003/diff/20001/tests/compiler/dart2js/p...
File tests/compiler/dart2js/parser_helper.dart (right):

https://codereview.chromium.org/169763003/diff/20001/tests/compiler/dart2js/p...
tests/compiler/dart2js/parser_helper.dart:55: void reportWarningCode(Spannable
node, MessageKind errorCode, [Map arguments]) {
On 2014/02/19 14:57:40, floitsch wrote:
> long line.
> 
> Why do we need a reportWarningCode?
> Shouldn't it be simply reportWarning?

Nice catch. Renamed.

Expand Messages | Collapse Messages