Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart

Issue 169763003: Update dart2js diagnostics to prepare for filtering. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove optional Uri. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart
diff --git a/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart b/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart
index 3b688f9e821fca9fc2801ab664e4819cff157bda..dd70c694d817c26fb816388419b51d884ebcd170 100644
--- a/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart
+++ b/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart
@@ -15,18 +15,19 @@ abstract class DiagnosticListener {
{Node node, Token token, HInstruction instruction,
Element element});
- SourceSpan spanFromSpannable(Spannable node, [Uri uri]);
+ SourceSpan spanFromSpannable(Spannable node);
- void reportMessage(SourceSpan span, Diagnostic message, api.Diagnostic kind);
+ void reportError(Spannable node, MessageKind errorCode,
+ [Map arguments = const {}]);
- void reportError(Spannable node, MessageKind errorCode, [Map arguments]);
+ void reportWarning(Spannable node, MessageKind errorCode,
+ [Map arguments = const {}]);
- // TODO(johnniwinther): Rename to [reportWarning] when
- // [Compiler.reportWarning] has been removed.
- void reportWarningCode(Spannable node, MessageKind errorCode,
- [Map arguments = const {}]);
+ void reportHint(Spannable node, MessageKind errorCode,
+ [Map arguments = const {}]);
- void reportInfo(Spannable node, MessageKind errorCode, [Map arguments]);
+ void reportInfo(Spannable node, MessageKind errorCode,
+ [Map arguments = const {}]);
// TODO(ahe): We should not expose this here. Perhaps a
// [SourceSpan] should implement [Spannable], and we should have a

Powered by Google App Engine
This is Rietveld 408576698