Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: sdk/lib/_internal/compiler/implementation/elements/modelx.dart

Issue 169763003: Update dart2js diagnostics to prepare for filtering. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove optional Uri. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/elements/modelx.dart
diff --git a/sdk/lib/_internal/compiler/implementation/elements/modelx.dart b/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
index 37b0c3b3c257905ba32077f8255d522b1eb278c7..4c847a5de906bc1683a71b5dbb082d462f17437a 100644
--- a/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
+++ b/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
@@ -407,7 +407,7 @@ class WarnOnUseElementX extends ElementX implements WarnOnUseElement {
if (warning != null) {
Spannable spannable = warning.spannable;
if (spannable == null) spannable = usageSpannable;
- listener.reportWarningCode(
+ listener.reportWarning(
spannable, warning.messageKind, warning.messageArguments);
}
if (info != null) {
@@ -513,10 +513,8 @@ class ScopeX {
if (!identical(existing, element)) {
listener.reportError(
element, MessageKind.DUPLICATE_DEFINITION, {'name': name});
- listener.reportMessage(
- listener.spanFromSpannable(existing),
- MessageKind.EXISTING_DEFINITION.error({'name': name}),
- api.Diagnostic.INFO);
+ listener.reportInfo(existing,
+ MessageKind.EXISTING_DEFINITION, {'name': name});
}
}
}
@@ -616,10 +614,7 @@ class CompilationUnitElementX extends ElementX
return;
}
if (partTag != null) {
- listener.reportMessage(
- listener.spanFromSpannable(tag),
- MessageKind.DUPLICATED_PART_OF.error(),
- api.Diagnostic.WARNING);
+ listener.reportWarning(tag, MessageKind.DUPLICATED_PART_OF);
return;
}
partTag = tag;
@@ -628,12 +623,12 @@ class CompilationUnitElementX extends ElementX
if (libraryTag != null) {
String expectedName = libraryTag.name.toString();
if (expectedName != actualName) {
- listener.reportWarningCode(tag.name,
+ listener.reportWarning(tag.name,
MessageKind.LIBRARY_NAME_MISMATCH,
{'libraryName': expectedName});
}
} else {
- listener.reportWarningCode(getLibrary(),
+ listener.reportWarning(getLibrary(),
MessageKind.MISSING_LIBRARY_NAME,
{'libraryName': actualName});
listener.reportInfo(tag.name,

Powered by Google App Engine
This is Rietveld 408576698