Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697263002: Remove HostDesktopType from some extensions files (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-28
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from some extensions files R=benwells@chromium.org BUG=558054 Committed: https://crrev.com/0d162016a2f107fa9bdcb9d110d98414aa3f04f9 Cr-Commit-Position: refs/heads/master@{#376568}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Patch Set 3 : unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M chrome/browser/extensions/bookmark_app_helper.cc View 1 2 1 chunk +14 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Depends on Patchset:

Issue 1694333002 Patch 40001

Dependent Patchsets:

Issue 1702523002 Patch 40001

Messages

Total messages: 9 (3 generated)
scottmg
4 years, 10 months ago (2016-02-16 01:12:30 UTC) #1
benwells
lgtm with a nit https://codereview.chromium.org/1697263002/diff/1/chrome/browser/extensions/bookmark_app_helper.cc File chrome/browser/extensions/bookmark_app_helper.cc (right): https://codereview.chromium.org/1697263002/diff/1/chrome/browser/extensions/bookmark_app_helper.cc#newcode719 chrome/browser/extensions/bookmark_app_helper.cc:719: #endif // USE_ASH nit: be ...
4 years, 10 months ago (2016-02-16 03:45:50 UTC) #2
scottmg
https://codereview.chromium.org/1697263002/diff/1/chrome/browser/extensions/bookmark_app_helper.cc File chrome/browser/extensions/bookmark_app_helper.cc (right): https://codereview.chromium.org/1697263002/diff/1/chrome/browser/extensions/bookmark_app_helper.cc#newcode719 chrome/browser/extensions/bookmark_app_helper.cc:719: #endif // USE_ASH On 2016/02/16 03:45:50, benwells wrote: > ...
4 years, 10 months ago (2016-02-19 21:51:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697263002/40001
4 years, 10 months ago (2016-02-19 22:35:01 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-19 23:20:53 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 23:21:59 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0d162016a2f107fa9bdcb9d110d98414aa3f04f9
Cr-Commit-Position: refs/heads/master@{#376568}

Powered by Google App Engine
This is Rietveld 408576698