Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 1702523002: Remove HostDesktopType from c/b/ui/views/apps/app_info_dialog (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-29
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from c/b/ui/views/apps/app_info_dialog R=sashab@chromium.org BUG=558054 Committed: https://crrev.com/2ebd17bbd50e961d2a31c00ae4c209a8e2443dd3 Cr-Commit-Position: refs/heads/master@{#376820}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc View 1 2 3 chunks +8 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
scottmg
4 years, 10 months ago (2016-02-16 01:16:20 UTC) #3
scottmg
up to higher level owners -> tapted
4 years, 10 months ago (2016-02-19 22:26:20 UTC) #5
tapted
lgtm %nit https://codereview.chromium.org/1702523002/diff/20001/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc File chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc (right): https://codereview.chromium.org/1702523002/diff/20001/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc#newcode10 chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:10: #include "chrome/browser/ui/host_desktop.h" nit: can this include go?
4 years, 10 months ago (2016-02-22 03:01:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702523002/40001
4 years, 10 months ago (2016-02-22 20:55:30 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-22 21:52:04 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2ebd17bbd50e961d2a31c00ae4c209a8e2443dd3 Cr-Commit-Position: refs/heads/master@{#376820}
4 years, 10 months ago (2016-02-22 21:53:41 UTC) #13
scottmg
4 years, 10 months ago (2016-02-25 20:01:39 UTC) #14
Message was sent while issue was closed.
(Oops, forgot to mail.)

https://codereview.chromium.org/1702523002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
(right):

https://codereview.chromium.org/1702523002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:10:
#include "chrome/browser/ui/host_desktop.h"
On 2016/02/22 03:01:49, tapted wrote:
> nit: can this include go?

Done.

Powered by Google App Engine
This is Rietveld 408576698