Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1694333002: Remove HostDesktopType from c/b/ui/views/tabs (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-27
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from c/b/ui/views/tabs R=sky@chromium.org BUG=558054 Committed: https://crrev.com/99a6c961efaed3cb366e7470507208f8d53912b1 Cr-Commit-Position: refs/heads/master@{#376545}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase and linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -70 lines) Patch
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 3 chunks +9 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 2 7 chunks +32 lines, -44 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 1 chunk +7 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
scottmg
4 years, 10 months ago (2016-02-16 01:06:18 UTC) #3
sky
LGTM
4 years, 10 months ago (2016-02-16 03:02:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694333002/1
4 years, 10 months ago (2016-02-18 18:04:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/95125) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-18 18:31:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694333002/40001
4 years, 10 months ago (2016-02-19 21:36:43 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-19 22:07:36 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 22:08:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/99a6c961efaed3cb366e7470507208f8d53912b1
Cr-Commit-Position: refs/heads/master@{#376545}

Powered by Google App Engine
This is Rietveld 408576698