Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1689423003: Remove HostDesktopType from remote dev tools (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from remote dev tools R=sky@chromium.org BUG=558054 Committed: https://crrev.com/9ed5c1481dc8544cc63ad87d4b6d58060f7a93f9 Cr-Commit-Position: refs/heads/master@{#375509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M chrome/browser/browser_process.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1697183003 Patch 1
Issue 1697183003 Patch 20001
Issue 1697183003 Patch 40001

Messages

Total messages: 9 (2 generated)
scottmg
4 years, 10 months ago (2016-02-15 19:45:42 UTC) #1
sky
LGTM - I was going to ask you to remote includes, but no doubt you'll ...
4 years, 10 months ago (2016-02-16 02:52:14 UTC) #2
sky
remote->remove
4 years, 10 months ago (2016-02-16 02:52:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689423003/1
4 years, 10 months ago (2016-02-16 02:53:38 UTC) #5
scottmg
On 2016/02/16 02:52:28, sky wrote: > remote->remove Yeah, I got some of them, but hopefully ...
4 years, 10 months ago (2016-02-16 02:53:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 03:37:57 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:51:15 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ed5c1481dc8544cc63ad87d4b6d58060f7a93f9
Cr-Commit-Position: refs/heads/master@{#375509}

Powered by Google App Engine
This is Rietveld 408576698